Integrate oracles result handling #3850
Open
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2025
Open
piotmag769
reviewed
Oct 22, 2025
crates/cheatnet/src/runtime_extensions/forge_runtime_extension/mod.rs
Outdated
Show resolved
Hide resolved
cptartur
force-pushed
the
spr/master/17bfed5d
branch
from
20301a1 to
739b6a0
Compare
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
5be308b to
2fb1cab
Compare
Open
piotmag769
reviewed
Oct 24, 2025
| StarknetApi(#[from] StarknetApiError), | ||
| #[error("Failed to parse {path} file")] | ||
| FileParsing { path: String }, | ||
| #[error("{error}")] |
Member
There was a problem hiding this comment.
Is the conversion chain ByteArray -> String -> ByteArray a noop? It would be better to just have impl From<EnhancedHintError> for ByteArray at this point imo since this is what happens here
Member
Author
There was a problem hiding this comment.
It's noop, or at least it should be. I'll try what you've suggested
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
2fb1cab to
5f1378b
Compare
cptartur
force-pushed
the
spr/master/17bfed5d
branch
from
739b6a0 to
5d0a998
Compare
This was referenced Nov 7, 2025
cptartur
force-pushed
the
spr/master/17bfed5d
branch
from
5d0a998 to
b951f65
Compare
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
from
5f1378b to
61e2887
Compare
cptartur
force-pushed
the
spr/master/17bfed5d
branch
from
b951f65 to
90f3cb8
Compare
cptartur
force-pushed
the
spr/master/30d7f8cd
branch
2 times, most recently
from
b6dbc2c to
7a5f8b2
Compare
cptartur
force-pushed
the
spr/master/17bfed5d
branch
from
90f3cb8 to
6f0e601
Compare
cptartur
requested review from
ddoktorski,
franciszekjob and
ksew1
and removed request for
a team and
ddoktorski
cptartur
force-pushed
the
spr/master/17bfed5d
branch
from
6f0e601 to
5ab7232
Compare
commit-id:17bfed5d
cptartur
force-pushed
the
spr/master/17bfed5d
branch
from
5ab7232 to
a18b3d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
RawFeltVec#3849