Skip to content

Commit 9744821

Browse files
sam-f0sam-f0
authored andcommitted
Android version required. If struct paths supplied those are used, but version must be supplied.
1 parent ca0ea53 commit 9744821

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ You'll need a rooted Android device or emulator.
5151
| -d DEVICE | The device to attach to e.g. "emulator-5554". Use `adb devices` to list available devices. If not provided defaults to the USB device. |
5252
| -p PID | The pid of the process on DEVICE to attach to. |
5353
| -n NAME | The name of the process on DEVICE to attach to e.g. "Messaging". |
54-
| -a [9, 10, 11, 13] | The version of android to load structures for. |
54+
| -a [9, 10, 11, 12, 13] | The target device android version. If no struct path is supplied, default structs are used. |
5555
| -s STRUCTPATH | The path to the directory of structure files. |
5656
| -c CONFIG | The path to the config file to filter. |
5757
| --spawn  | Spawn process before attaching. -n option **must** be present and contain a valid process identifier.|

binder_trace/binder_trace/__main__.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,16 @@ def setupArgParser() -> argparse.ArgumentParser:
4141
help="the android device to attach to",
4242
)
4343

44-
struct_group = parser.add_mutually_exclusive_group(required=True)
45-
46-
struct_group.add_argument(
44+
parser.add_argument(
4745
"-a",
4846
"--android-version",
4947
nargs="?",
5048
choices=["9", "10", "11", "12", "13", "14"],
5149
help="Android version structs to use",
50+
required=True,
5251
)
5352

54-
struct_group.add_argument(
53+
parser.add_argument(
5554
"-s",
5655
"--structpath",
5756
help="Provides the path to the root of the struct directory. e.g. ../structs/android11",

0 commit comments

Comments
 (0)