Skip to content

Commit 6d0048e

Browse files
committed
Work around samefile bug
1 parent 78508a8 commit 6d0048e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

acquire/acquire.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1649,7 +1649,9 @@ def _run(cls, target: Target, cli_args: argparse.Namespace, collector: Collector
16491649

16501650
for _, mountpoint, uuid, _ in iter_esxi_filesystems(target):
16511651
for bootbank_path, boot_vol in boot_fs:
1652-
if bootbank_path.samefile(mountpoint):
1652+
# samefile fails on python 3.9 (https://github.com/fox-it/dissect.target/issues/1289)
1653+
# but support for 3.9 gets dropped soon
1654+
if bootbank_path.samefile(target.fs.path(mountpoint)):
16531655
log.info("Acquiring %s (%s)", mountpoint, boot_vol)
16541656
mountpoint_len = len(mountpoint)
16551657
base = f"fs/{uuid}:{boot_vol}"

0 commit comments

Comments
 (0)