fix: change assert_never to runtim errors

Author: twiggler

dissect/target/helpers/nfs/client.py

@@ -53,7 +53,7 @@ def __exit__(self, _: type[BaseException] | None, __: BaseException | None, ___:
         return False  # Reraise exceptions
 
     @classmethod
-    def connect(cls, hostname: str, port: int, auth: AuthScheme[Credentials, Verifier], local_port: int) -> "Client":
+    def connect(cls, hostname: str, port: int, auth: AuthScheme[Credentials, Verifier], local_port: int) -> Client:
         rpc_client = SunRpcClient.connect(hostname, port, auth, local_port)
         return Client(rpc_client)
 

dissect/target/helpers/sunrpc/client.py

@@ -67,13 +67,11 @@ class Client(AbstractContextManager, Generic[Credentials, Verifier]):
     PMAP_PORT = 111
 
     @classmethod
-    def connect_port_mapper(cls, hostname: str) -> "Client":
+    def connect_port_mapper(cls, hostname: str) -> Client:
         return cls.connect(hostname, cls.PMAP_PORT, auth_null())
 
     @classmethod
-    def connect(
-        cls, hostname: str, port: int, auth: AuthScheme[Credentials, Verifier], local_port: int = 0
-    ) -> "Client":
+    def connect(cls, hostname: str, port: int, auth: AuthScheme[Credentials, Verifier], local_port: int = 0) -> Client:
         sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
         sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
         sock.bind(("", local_port))

dissect/target/helpers/sunrpc/serializer.py

@@ -3,7 +3,7 @@
 import io
 from abc import ABC, abstractmethod
 from enum import IntEnum
-from typing import Generic, Type, TypeVar, assert_never
+from typing import Generic, Type, TypeVar
 
 from dissect.target.helpers.sunrpc import sunrpc
 
@@ -254,7 +254,8 @@ def deserialize(
         elif reply_stat == ReplyStat.MSG_DENIED:
             reply = self._read_rejected_reply(payload)
         else:
-            assert_never(reply_stat)
+            # assert_never is slightly better, but only available starting from Python 3.11
+            raise ValueError(f"Unexpected value for reply_stat {reply_stat}")
 
         return sunrpc.Message(xid, reply)
 
@@ -290,7 +291,8 @@ def _read_rejected_reply(self, payload: io.BytesIO) -> sunrpc.RejectedReply:
             auth_stat = self._read_enum(payload, sunrpc.AuthStat)
             return sunrpc.RejectedReply(reject_stat, auth_stat)
         else:
-            assert_never(reject_stat)
+            # assert_never is slightly better, but only available starting from Python 3.11
+            raise ValueError(f"Unexpected value for reject_stat: {reject_stat}")
 
     def _read_mismatch(self, payload: io.BytesIO) -> sunrpc.Mismatch:
         low = self._read_uint32(payload)