feature: add nlink support for jffs stat (#1064)

Author: twiggler

dissect/target/filesystems/jffs.py

@@ -109,7 +109,7 @@ def lstat(self) -> fsutil.stat_result:
                 self.entry.mode,
                 self.entry.inum,
                 id(self.fs),
-                1,  # TODO: properly calculate nlink in dissect.jffs
+                self.entry.nlink,
                 node.uid,
                 node.gid,
                 node.isize,

pyproject.toml

@@ -57,7 +57,7 @@ full = [
     "dissect.fat>=3,<4",
     "dissect.ffs>=3,<4",
     "dissect.fve>=4,<5; platform_system != 'Windows' or platform_python_implementation != 'PyPy'",
-    "dissect.jffs>=1,<2",
+    "dissect.jffs>=1.5.dev,<2",     # TODO: update on release 
     "dissect.ole>=3,<4",
     "dissect.shellitem>=3,<4",
     "dissect.squashfs>=1,<2",
@@ -95,7 +95,7 @@ dev = [
     "dissect.ffs[dev]>=3.0.dev,<4.0.dev",
     "dissect.fve[dev]>=4.0.dev,<5.0.dev; platform_system != 'Windows' or platform_python_implementation != 'PyPy'",
     "dissect.hypervisor[dev]>=3.0.dev,<4.0.dev",
-    "dissect.jffs[dev]>=1.0.dev,<2.0.dev",
+    "dissect.jffs[dev]>=1.5.dev,<2.0.dev",
     "dissect.ntfs[dev]>=3.4.dev,<4.0.dev",
     "dissect.regf[dev]>=3.3.dev,<4.0.dev",
     "dissect.shellitem[dev]>=3.0.dev,<4.0.dev",

tests/filesystems/test_jffs2.py

@@ -20,6 +20,7 @@ def jffs_fs_file_entry(jffs_fs: JFFSFilesystem) -> Iterator[JFFSFilesystemEntry]
     inode = Mock(
         mode=0o100664,
         inum=4,
+        nlink=1,
         inode=raw_inode,
         atime=datetime(2024, 10, 1, 12, 0, 0),
         mtime=datetime(2024, 10, 2, 12, 0, 0),
@@ -39,6 +40,7 @@ def jffs_fs_directory_entry(jffs_fs: JFFSFilesystem) -> Iterator[JFFSFilesystemE
     inode = Mock(
         mode=0o40775,
         inum=2,
+        nlink=2,
         inode=raw_inode,
         atime=datetime(2024, 10, 1, 12, 0, 0),
         mtime=datetime(2024, 10, 2, 12, 0, 0),
@@ -63,7 +65,7 @@ def test_jffs2_stat(entry_fixture: str, expected_blocks: int, request: pytest.Fi
     assert stat.st_mode == entry.mode
     assert stat.st_ino == entry.inum
     assert stat.st_dev == id(jffs_entry.fs)
-    assert stat.st_nlink == 1
+    assert stat.st_nlink == entry.nlink
     assert stat.st_uid == entry.inode.uid
     assert stat.st_gid == entry.inode.gid
     assert stat.st_size == entry.inode.isize