fix: Clear property config on process_authority() (#507)

Fixes #495

Author: elementbound

addons/netfox.extras/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.extras"
 description="Game-specific utilities for Netfox"
 author="Tamas Galffy and contributors"
-version="1.32.2"
+version="1.32.3"
 script="netfox-extras.gd"

addons/netfox.internals/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.internals"
 description="Shared internals for netfox addons"
 author="Tamas Galffy and contributors"
-version="1.32.2"
+version="1.32.3"
 script="plugin.gd"

addons/netfox.noray/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.noray"
 description="Bulletproof your connectivity with noray integration for netfox"
 author="Tamas Galffy and contributors"
-version="1.32.2"
+version="1.32.3"
 script="netfox-noray.gd"

addons/netfox/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox"
 description="Shared internals for netfox addons"
 author="Tamas Galffy and contributors"
-version="1.32.2"
+version="1.32.3"
 script="netfox.gd"

addons/netfox/properties/property-config.gd

@@ -6,12 +6,16 @@ var _auth_properties: Dictionary = {} # Peer (int) to owned properties (Array[Pr
 
 var local_peer_id: int
 
+func clear() -> void:
+	_properties.clear()
+	_auth_properties.clear()
+
 func set_properties(p_properties: Array[PropertyEntry]) -> void:
+	clear()
 	_properties.assign(p_properties)
-	_auth_properties.clear()
 
 func set_properties_from_paths(property_paths: Array[String], property_cache: PropertyCache) -> void:
-	_properties.clear()
+	clear()
 	for path in property_paths:
 		_properties.append(property_cache.get_entry(path))
 

test/netfox/properties/property-config.test.gd

@@ -32,6 +32,25 @@ func suite():
 		expect_empty(config.get_properties_owned_by(LOCAL_PEER))
 	)
 
+	test("should get remote owned properties after ownership change", func():
+		var properties := SnapshotFixtures.state_properties()
+		var cache := PropertyCache.new(remote_node)
+		var config := _PropertyConfig.new()
+		config.set_properties_from_paths(SnapshotFixtures.state_properties(), cache)
+		config.local_peer_id = LOCAL_PEER
+
+		expect_empty(config.get_owned_properties())
+
+		# Update ownership
+		remote_node.set_multiplayer_authority(1)
+		config.set_properties_from_paths(SnapshotFixtures.state_properties(), cache)
+
+		# Convert to a list of property paths for easier comparison
+		var owned_properties := config.get_owned_properties()\
+			.map(func(it): return str(it))
+		expect_equal(owned_properties, properties)
+	)
+
 	on_finish.connect(func():
 		local_node.queue_free()
 		remote_node.queue_free()

test/snapshot-fixtures.gd

@@ -8,12 +8,19 @@ static func state_snapshot(p_position: Vector3 = Vector3.ONE) -> _PropertySnapsh
 		":health": 100.
 	})
 
+static func state_properties() -> Array[String]:
+	var result: Array[String] = [
+		":position",
+		":velocity",
+		":health"
+	]
+	return result
+
 static func state_propery_entries(root_node: Node) -> Array[PropertyEntry]:
 	var result: Array[PropertyEntry] = []
-	result.append(PropertyEntry.parse(root_node, ":position"))
-	result.append(PropertyEntry.parse(root_node, ":velocity"))
-	result.append(PropertyEntry.parse(root_node, ":health"))
-
+	result.assign(state_properties().map(func(path):
+		return PropertyEntry.parse(root_node, path)
+	))
 	return result
 
 static func state_node() -> StateNode: