fix: Queue RewindableAction mutations ahead of rollback loop (#531)

Co-authored-by: Tamás Gálffy <ezittgtx@gmail.com>

Author: RevoluPowered

addons/netfox.extras/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.extras"
 description="Game-specific utilities for Netfox"
 author="Tamas Galffy and contributors"
-version="1.35.1"
+version="1.35.2"
 script="netfox-extras.gd"

addons/netfox.internals/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.internals"
 description="Shared internals for netfox addons"
 author="Tamas Galffy and contributors"
-version="1.35.1"
+version="1.35.2"
 script="plugin.gd"

addons/netfox.noray/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.noray"
 description="Bulletproof your connectivity with noray integration for netfox"
 author="Tamas Galffy and contributors"
-version="1.35.1"
+version="1.35.2"
 script="netfox-noray.gd"

addons/netfox/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox"
 description="Shared internals for netfox addons"
 author="Tamas Galffy and contributors"
-version="1.35.1"
+version="1.35.2"
 script="netfox.gd"

addons/netfox/rewindable-action.gd

@@ -173,6 +173,12 @@ func _before_rollback_loop() -> void:
 		for tick in _queued_changes:
 			set_active(_queued_changes[tick], tick)
 
+	# Queue earliest event
+	if not _active_ticks.is_empty():
+		var earliest_active = _active_ticks.min()
+		for mutated in _mutated_objects:
+			NetworkRollback.mutate(mutated, earliest_active)
+
 func _after_loop() -> void:
 	# Trim history
 	for tick in _active_ticks:
@@ -195,12 +201,6 @@ func _after_loop() -> void:
 	_state_changes.clear()
 	_queued_changes.clear()
 
-	# Queue earliest event
-	if not _active_ticks.is_empty():
-		var earliest_active = _active_ticks.min()
-		for mutated in _mutated_objects:
-			NetworkRollback.mutate(mutated, earliest_active)
-
 	# Submit
 	if is_multiplayer_authority() and _last_set_tick >= 0:
 		var active_tick_bytes = _TicksetSerializer.serialize(NetworkRollback.history_start, _last_set_tick, _active_ticks)
@@ -220,8 +220,11 @@ func _submit_state(bytes: PackedByteArray) -> void:
 	# Don't compare past last event, as to not cancel events the host simply doesn't know about
 	var latest_tick = maxi(last_known_tick, NetworkRollback.history_start)
 
-	if earliest_tick > NetworkTime.tick or latest_tick > NetworkTime.tick:
-		_logger.warning("Received tickset for range @%d>%d, which has ticks in the future!", [earliest_tick, latest_tick])
+	# Add a tolerance of 4 ticks for checking if the tickset is in the future
+	# Server time might be ahead a tick or two under really small latencies,
+	# e.g. LAN
+	if earliest_tick > NetworkTime.tick + 4 or latest_tick > NetworkTime.tick + 4:
+		_logger.debug("Received tickset for range @%d>%d, which has ticks in the future!", [earliest_tick, latest_tick])
 
 	for tick in range(earliest_tick, latest_tick + 1):
 		var is_tick_active = active_ticks.has(tick)