Either::filterOrElse: Passing R to $left callback

Author: klimick

src/Fp/Functional/Either/Either.php

@@ -682,7 +682,7 @@ public function swap(): Either
      * @template LO
      *
      * @param callable(R): bool $callback
-     * @param callable(): LO $left
+     * @param callable(R): LO $left
      * @return Either<L|LO, R>
      */
     public function filterOrElse(callable $callback, callable $left): Either
@@ -691,7 +691,7 @@ public function filterOrElse(callable $callback, callable $left): Either
             /** @param L $l */
             fn(mixed $l) => Either::left($l),
             /** @param R $r */
-            fn(mixed $r) => $callback($r) ? Either::right($r) : Either::left($left()),
+            fn(mixed $r) => $callback($r) ? Either::right($r) : Either::left($left($r)),
         );
     }
 

tests/Runtime/Classes/Either/EitherTest.php

@@ -350,8 +350,8 @@ public function testFilterOrElseToLeft(): void
         $num = Either::right(9);
 
         $this->assertEquals(
-            Either::left('Less than 10'),
-            $num->filterOrElse(fn($i) => $i >= 10, fn() => 'Less than 10'),
+            Either::left('9 is less than 10'),
+            $num->filterOrElse(fn($i) => $i >= 10, fn($i) => "{$i} is less than 10"),
         );
     }