java: Optimize StringUtils

Avoid unboxing to Character

Author: mpkorstanje

java/src/main/java/io/cucumber/gherkin/PickleCompiler.java

@@ -187,7 +187,7 @@ private PickleTable pickleDataTable(DataTable dataTable, List<TableCell> variabl
         List<PickleTableRow> newRows = new ArrayList<>(rows.size());
         for (TableRow row : rows) {
             List<TableCell> cells = row.getCells();
-            List<PickleTableCell> newCells = new ArrayList<>();
+            List<PickleTableCell> newCells = new ArrayList<>(cells.size());
             for (TableCell cell : cells) {
                 newCells.add(new PickleTableCell(interpolate(cell.getValue(), variableCells, valueCells)));
             }

java/src/main/java/io/cucumber/gherkin/StringUtils.java

@@ -106,7 +106,7 @@ private static int findFirstIndexIn(String input, char[] characters) {
     }
 
     private static boolean contains(char[] characters, char c) {
-        for (Character candidate : characters) {
+        for (char candidate : characters) {
             if (candidate == c) {
                 return true;
             }

java/src/test/java/io/cucumber/gherkin/GherkinParserTest.java

@@ -14,10 +14,13 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.Paths;
+import java.util.List;
 import java.util.Optional;
 import java.util.stream.Stream;
 
 import static io.cucumber.messages.types.SourceMediaType.TEXT_X_CUCUMBER_GHERKIN_PLAIN;
+import static java.util.stream.Collectors.toList;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -37,14 +40,23 @@ void use_this_in_readme() {
     }
 
     @Test
-    void can_parse_streams() throws IOException {
-        try (InputStream is = new ByteArrayInputStream(feature.getBytes(StandardCharsets.UTF_8))){
-            GherkinParser parser = GherkinParser.builder().build();
-            Stream<Envelope> pickles = parser.parse("minimal.feature",is).filter(envelope -> envelope.getPickle().isPresent());
-            assertEquals(1, pickles.count());
+    void test_for_profiler_parser() throws IOException {
+        for (int i = 0; i < 1000; i++) {
+            GherkinParser.builder().build().parse(Paths.get("../testdata/good/very_long.feature"));
         }
     }
 
+    @Test
+    void can_parse_streams() throws IOException {
+        InputStream is = new ByteArrayInputStream(feature.getBytes(StandardCharsets.UTF_8));
+        GherkinParser parser = GherkinParser.builder()
+                .includeSource(false)
+                .includeGherkinDocument(false)
+                .build();
+        List<Envelope> pickles = parser.parse("minimal.feature", is).collect(toList());
+        assertTrue(pickles.get(0).getPickle().isPresent());
+    }
+
     @Test
     void provides_access_to_the_ast() {
         // Get the AST