[PerlCritic] avoid double-sigil dereference

see https://metacpan.org/pod/Perl::Critic::Policy::References::ProhibitDoubleSigils

Author: fperrad

perl/lib/Gherkin.pm

@@ -32,7 +32,7 @@ sub from_paths {
     my ($class, $paths, $id_generator, $sink, %options) = @_;
 
     my $gherkin = $class->new(%options);
-    for my $path (@$paths) {
+    for my $path (@{$paths}) {
         # Note: There's a huge difference between ':utf8' and
         # ':encoding(UTF-8)' in Perl: the latter causes strict UTF-8 conversion
         # and fails hard if there are encoding problems. The former

perl/lib/Gherkin/AstBuilder.pm

@@ -121,11 +121,11 @@ sub get_table_rows {
 
 sub ensure_cell_count {
     my ( $self, $rows ) = @_;
-    return unless @$rows;
+    return unless @{$rows};
 
     my $cell_count;
 
-    for my $row (@$rows) {
+    for my $row (@{$rows}) {
         my $this_row_count = @{ $row->cells };
         $cell_count = $this_row_count unless defined $cell_count;
         unless ( $cell_count == $this_row_count ) {
@@ -182,7 +182,7 @@ sub transform_node {
         my $media_type      = $separator_token->matched_text;
         my $delimiter       = $separator_token->matched_keyword;
         my $line_tokens     = $node->get_tokens('Other');
-        my $content = join( "\n", map { $_->matched_text } @$line_tokens );
+        my $content = join( "\n", map { $_->matched_text } @{$line_tokens} );
 
         return Cucumber::Messages::DocString->new(
             location    => $self->get_location($separator_token),

perl/lib/Gherkin/Line.pm

@@ -121,7 +121,7 @@ sub table_cells {
         $stripped_cell =~ s/\s+$//;
         $stripped_cell =~ s/(\\\\|\\\||\\n)/$unescape_map{$1}/g;
         push(
-            @$cells,
+            @{$cells},
             {
                 column => $col + $self->indent + $cell_indent,
                 text   => $stripped_cell

perl/lib/Gherkin/Pickles/Compiler.pm

@@ -78,7 +78,7 @@ sub _compile_scenario {
         }
     }
 
-    my @all_tags = (@$tags, @{ $scenario->tags || [] });
+    my @all_tags = (@{$tags}, @{ $scenario->tags || [] });
     $pickle_sink->(
         Cucumber::Messages::Envelope->new(
             pickle => Cucumber::Messages::Pickle->new(
@@ -152,7 +152,7 @@ sub _compile_rule {
     my ( $class, $uri, $feature_tags, $feature_background_steps,
          $rule_definition, $language, $id_generator, $pickle_sink )
         = @_;
-    my @background_steps = ( @$feature_background_steps );
+    my @background_steps = ( @{$feature_background_steps} );
     my @tags = (
         @{ $feature_tags || [] },
         @{ $rule_definition->tags || [] }
@@ -241,7 +241,7 @@ sub _pickle_step_props {
 
 sub _pickle_tags {
     my ( $class, $tags ) = @_;
-    return [ map { $class->_pickle_tag( $_ ) } @$tags ];
+    return [ map { $class->_pickle_tag( $_ ) } @{$tags} ];
 }
 
 sub _pickle_tag {

perl/lib/Gherkin/TokenMatcher.pm

@@ -27,7 +27,7 @@ sub new {
 sub _add_keyword_type_mappings {
     my ($keyword_types, $keywords, $type) = @_;
 
-    for my $keyword (@$keywords) {
+    for my $keyword (@{$keywords}) {
         if (not exists $keyword_types->{$keyword}) {
             $keyword_types->{$keyword} = [];
         }
@@ -122,7 +122,7 @@ sub _match_title_line {
     my ( $self, $token, $token_type, $keywords ) = @_;
     return unless $token->line;
 
-    for my $keyword (@$keywords) {
+    for my $keyword (@{$keywords}) {
         if ( $token->line->startswith_title_keyword($keyword) ) {
             my $title =
               $token->line->get_rest_trimmed( length( $keyword . ': ' ) );

perl/t/020_parser_instantiation.t

@@ -22,7 +22,7 @@ for (
     [ stringref => \$content ], # By content
     [ scanner => Gherkin::TokenScanner->new( '' . $file ) ], # Object
 ) {
-    my ( $type, $input ) = @$_;
+    my ( $type, $input ) = @{$_};
     $results{ $type } = Gherkin::Parser->new->parse( $input );
     ok( 'true', "Parsing via $type lived" );
 }