[PerlCritic] avoid useless interpolation

see https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::ProhibitInterpolationOfLiterals

Author: fperrad

perl/gherkin-perl.razor

@@ -18,8 +18,8 @@
 {<text>    $token->detach;
     $err = $self->_construct_parser_error(
         $token,
-        ["@Raw(string.Join("\", \"", expectedTokens))"],
-        "State: @state.Id - @Raw(state.Comment)",
+        ['@Raw(string.Join("', '", expectedTokens))'],
+        'State: @state.Id - @Raw(state.Comment)',
     );
     $self->add_error( $context, $err );
 
@@ -38,7 +38,7 @@ use base 'Gherkin::ParserBase';
 my %states_to_match_names = (
     @foreach(var state in Model.States.Values.Where(s => !s.IsEndState)) //..
     {
-@:    @state.Id => "match_token_at_@(state.Id)",
+@:    @state.Id => 'match_token_at_@(state.Id)',
     }
 );
 
@@ -88,7 +88,7 @@ sub match_token {
 
 sub _construct_parser_error {
     my ($self, $token, @@args) = @@_;
-    my $error_class = "Gherkin::Exceptions::" . (
+    my $error_class = 'Gherkin::Exceptions::' . (
         $token->is_eof ? 'UnexpectedEOF' : 'UnexpectedToken' );
 
     return $error_class->new( $token, @@args );

perl/lib/Gherkin/AstBuilder.pm

@@ -79,7 +79,7 @@ sub get_location {
     my ( $self, $token, $column ) = @_;
 
     use Carp qw/confess/;
-    confess "What no token?" unless $token;
+    confess 'What no token?' unless $token;
 
     return Cucumber::Messages::Location->new(
         line   => $token->location->{'line'},
@@ -134,7 +134,7 @@ sub ensure_cell_count {
         $cell_count = $this_row_count unless defined $cell_count;
         unless ( $cell_count == $this_row_count ) {
             Gherkin::Exceptions::AstBuilder->throw(
-                "inconsistent cell count within the table",
+                'inconsistent cell count within the table',
                 $row->location );
         }
     }
@@ -235,12 +235,12 @@ sub transform_node {
     } elsif ( $node->rule_type eq 'Rule' ) {
         my $header = $node->get_single('RuleHeader');
         unless ($header) {
-            warn "Missing RuleHeader!";
+            warn 'Missing RuleHeader!';
             return;
         }
         my $rule_line = $header->get_token('RuleLine');
         unless ($rule_line) {
-            warn "Missing RuleLine";
+            warn 'Missing RuleLine';
             return;
         }
         my $tags = $self->get_tags($header);
@@ -302,12 +302,12 @@ sub transform_node {
     } elsif ( $node->rule_type eq 'Feature' ) {
         my $header = $node->get_single('FeatureHeader');
         unless ($header) {
-            warn "Missing FeatureHeader!";
+            warn 'Missing FeatureHeader!';
             return;
         }
         my $feature_line = $header->get_token('FeatureLine');
         unless ($feature_line) {
-            warn "Missing FeatureLine";
+            warn 'Missing FeatureLine';
             return;
         }
         my $tags = $self->get_tags($header);

perl/lib/Gherkin/Exceptions.pm

@@ -63,7 +63,7 @@ sub new {
 
 sub detailed_message {
     my $self = shift;
-    return "Language not supported: " . $self->language;
+    return 'Language not supported: ' . $self->language;
 }
 
 package Gherkin::Exceptions::AstBuilder;
@@ -98,7 +98,7 @@ sub new {
 
 sub detailed_message {
     my $self = shift;
-    return "unexpected end of file, expected: " . join ', ',
+    return 'unexpected end of file, expected: ' . join ', ',
         @{ $self->expected_token_types };
 }
 
@@ -131,7 +131,7 @@ sub new {
 sub detailed_message {
     my $self = shift;
     return sprintf(
-        "expected: %s, got '%s'",
+        'expected: %s, got \'%s\'',
         ( join ', ', @{ $self->expected_token_types } ),
         $self->received_token_value,
     );