[PerlCritic] remove useless parentheses for builtin

Author: fperrad

perl/gherkin-perl.razor

@@ -142,7 +142,7 @@ sub lookahead_@(lookAheadHint.Id) {
     while (1) {
         $token = $context->read_token();
         $token->detach;
-        push( @@queue, $token );
+        push @@queue, $token;
 
         @foreach(var tokenType in lookAheadHint.ExpectedTokens) {<text>
         ($match) = @MatchToken(tokenType);

perl/lib/Gherkin.pm

@@ -68,7 +68,7 @@ sub _parse_source_encoding_header {
     my $header_end = 0;
     my @header     = grep {
         not ($header_end ||= ($_ !~ m/^\s*#/))
-    } split( /\n/, $source->data );
+    } split /\n/, $source->data;
     my $encoding;
     for my $line (@header) {
         if ($line =~ m/\s*#\s+encoding:\s+(\S+)/) {

perl/lib/Gherkin/AstBuilder.pm

@@ -45,13 +45,13 @@ sub current_node {
 
 sub start_rule {
     my ( $self, $rule_type ) = @_;
-    push( @{ $self->{'stack'} }, ast_node($rule_type) );
+    push @{ $self->{'stack'} }, ast_node($rule_type);
     return;
 }
 
 sub end_rule {
     my ( $self, $rule_type ) = @_;
-    my $node = pop( @{ $self->{'stack'} } );
+    my $node = pop @{ $self->{'stack'} };
     $self->current_node->add( $node->rule_type, $self->transform_node($node) );
     return;
 }
@@ -187,7 +187,7 @@ sub transform_node {
         my $media_type      = $separator_token->matched_text;
         my $delimiter       = $separator_token->matched_keyword;
         my $line_tokens     = $node->get_tokens('Other');
-        my $content = join( "\n", map { $_->matched_text } @{$line_tokens} );
+        my $content = join "\n", map { $_->matched_text } @{$line_tokens};
 
         return Cucumber::Messages::DocString->new(
             location    => $self->get_location($separator_token),

perl/lib/Gherkin/AstNode.pm

@@ -12,7 +12,7 @@ sub new {
 
 sub add {
     my ( $self, $rule_type, $obj ) = @_;
-    push( @{ ( $self->{'_sub_items'}->{$rule_type} ||= [] ) }, $obj );
+    push @{ ( $self->{'_sub_items'}->{$rule_type} ||= [] ) }, $obj;
     return;
 }
 

perl/lib/Gherkin/Exceptions.pm

@@ -45,10 +45,10 @@ sub new {
 
 sub message {
     my $self = shift;
-    return sprintf( '(%i:%i): %s',
+    return sprintf '(%i:%i): %s',
         $self->location->{'line'},
         ( $self->location->{'column'} || 0 ),
-        $self->detailed_message );
+        $self->detailed_message;
 }
 
 package Gherkin::Exceptions::NoSuchLanguage;
@@ -130,11 +130,10 @@ sub new {
 
 sub detailed_message {
     my $self = shift;
-    return sprintf(
+    return sprintf
         'expected: %s, got \'%s\'',
         ( join ', ', @{ $self->expected_token_types } ),
-        $self->received_token_value,
-    );
+        $self->received_token_value;
 }
 
 1;

perl/lib/Gherkin/Generated/Parser.pm

@@ -3893,7 +3893,7 @@ sub lookahead_0 {
     while (1) {
         $token = $context->read_token();
         $token->detach;
-        push( @queue, $token );
+        push @queue, $token;
 
 
         ($match) = $context->token_matcher->match_ScenarioLine($token);
@@ -3924,7 +3924,7 @@ sub lookahead_1 {
     while (1) {
         $token = $context->read_token();
         $token->detach;
-        push( @queue, $token );
+        push @queue, $token;
 
 
         ($match) = $context->token_matcher->match_ExamplesLine($token);

perl/lib/Gherkin/Line.pm

@@ -32,7 +32,7 @@ sub _build_indent {
 
 sub get_rest_trimmed {
     my ( $self, $from ) = @_;
-    my $rest = substr( $self->_trimmed_line_text, $from );
+    my $rest = substr $self->_trimmed_line_text, $from;
     $rest =~ s/^\s*//;
     $rest =~ s/\s*$//;
     return $rest;
@@ -45,7 +45,7 @@ sub get_line_text {
     if ( $indent_to_remove < 0 or $indent_to_remove > $self->indent ) {
         return $self->_trimmed_line_text;
     } else {
-        return substr( $self->line_text, $indent_to_remove );
+        return substr $self->line_text, $indent_to_remove;
     }
 }
 
@@ -57,13 +57,13 @@ sub is_empty {
 sub startswith {
     my ( $self, $prefix ) = @_;
     return unless defined $self->_trimmed_line_text;
-    return !index( $self->_trimmed_line_text, $prefix );
+    return !index $self->_trimmed_line_text, $prefix;
 }
 
 sub startswith_title_keyword {
     my ( $self, $prefix ) = @_;
     return unless defined $self->_trimmed_line_text;
-    return !index( $self->_trimmed_line_text, $prefix . ':' );
+    return !index $self->_trimmed_line_text, $prefix . ':';
 }
 
 sub _split_table_cells_iterator {
@@ -120,13 +120,12 @@ sub table_cells {
         my $cell_indent = length($cell) - length($stripped_cell);
         $stripped_cell =~ s/\s+$//;
         $stripped_cell =~ s/(\\\\|\\\||\\n)/$unescape_map{$1}/g;
-        push(
+        push
             @{$cells},
             {
                 column => $col + $self->indent + $cell_indent,
                 text   => $stripped_cell
-            }
-        );
+            };
     }
 
     return $cells;
@@ -140,8 +139,8 @@ sub tags {
 
     my @tags;
     my @errors;
-    my @items = split( /@/, $items_line );
-    shift(@items);    # Blank first item
+    my @items = split /@/, $items_line;
+    shift @items;    # Blank first item
 
     for my $untrimmed (@items) {
         my $item = $untrimmed;

perl/lib/Gherkin/ParserContext.pm

@@ -15,7 +15,7 @@ sub new {
     return bless $options, $class;
 }
 
-sub add_tokens { my $self = shift; push( @{ $self->token_queue }, @_ ); return; }
+sub add_tokens { my $self = shift; push @{ $self->token_queue }, @_; return; }
 sub errors     { my $self = shift; return @{ $self->_errors } }
 sub add_errors {
     my $self = shift;
@@ -24,7 +24,7 @@ sub add_errors {
 }
 
 sub read_token {
-    my ($self) = shift();
+    my ($self) = shift;
     return shift( @{ $self->token_queue } ) || $self->token_scanner->read;
 }
 

perl/lib/Gherkin/TokenFormatterBuilder.pm

@@ -15,7 +15,7 @@ sub formatted_tokens { return $_[0]->{'formatted_tokens'} }
 
 sub build {
     my ( $self, $token ) = @_;
-    push( @{ $self->formatted_tokens }, $self->format_token($token) );
+    push @{ $self->formatted_tokens }, $self->format_token($token);
     return;
 }
 
@@ -32,18 +32,17 @@ my $c = 0;
 sub format_token {
     my ( $self, $token ) = @_;
     return 'EOF' if $token->is_eof;
-    my $v = sprintf(
+    my $v = sprintf
         '(%s:%s)%s:%s/%s/%s',
         $token->location->{'line'},
         $token->location->{'column'},
         $token->matched_type || '',
         ( $token->matched_keyword ?
           sprintf('(%s)%s',$token->matched_keyword_type || '',$token->matched_keyword || '') : ''),
         $token->matched_text    || '',
-        join( ',',
+        join ',',
             map { $_->{'column'} . ':' . $_->{'text'} }
-              @{ $token->matched_items } )
-    );
+              @{ $token->matched_items };
     utf8::encode($v);
     return $v;
 }

perl/lib/Gherkin/TokenMatcher.pm

@@ -143,7 +143,7 @@ sub _set_token_matched {
     $token->matched_type($matched_type);
 
     if ( defined $options->{'text'} ) {
-        chomp( $options->{'text'} );
+        chomp $options->{'text'};
         $token->matched_text( $options->{'text'} );
     }
 
@@ -221,7 +221,7 @@ sub match_StepLine {
 
     for my $keyword (@keywords) {
         if ( $line->startswith($keyword) ) {
-            my $title = $line->get_rest_trimmed( length($keyword) );
+            my $title = $line->get_rest_trimmed( length $keyword );
             my $keyword_type =
                 (scalar @{$self->_keyword_types->{$keyword}} > 1)
                 ? Cucumber::Messages::Step::KEYWORDTYPE_UNKNOWN
@@ -259,7 +259,7 @@ sub _match_DocStringSeparator {
 
     my $content_type;
     if ($is_open) {
-        $content_type = $token->line->get_rest_trimmed( length($separator) );
+        $content_type = $token->line->get_rest_trimmed( length $separator );
         $self->_active_doc_string_separator($separator);
         $self->_indent_to_remove( $token->line->indent );
     } else {