Silence warnings

LibretroAdmin · LibretroAdmin · commit 5650d916084e · 2025-11-13T19:24:27.000+01:00
diff --git a/audio/drivers/coreaudio_mic_macos.m b/audio/drivers/coreaudio_mic_macos.m
@@ -285,12 +285,11 @@ void coreaudio_macos_microphone_free(void *data)
       propsize = 0;
       status = AudioObjectGetPropertyDataSize(current_device_id, &prop_addr_streams_input, 0, NULL, &propsize);
       if (status == noErr && propsize > 0)
-      {
          input_stream_count = propsize / sizeof(AudioStreamID); /* Can be more than 1, but we just need > 0 */
-      }
 
       if (input_stream_count > 0)
       {
+         CFStringRef device_uid_cf = NULL;
          /* This device has input streams, get its name and UID */
          CFStringRef device_name_cf = NULL;
          propsize = sizeof(CFStringRef);
@@ -299,9 +298,7 @@ void coreaudio_macos_microphone_free(void *data)
             kAudioObjectPropertyScopeGlobal,
             kAudioObjectPropertyElementMaster
          };
-         status = AudioObjectGetPropertyData(current_device_id, &prop_addr_name, 0, NULL, &propsize, &device_name_cf);
-
-         CFStringRef device_uid_cf = NULL;
+         status   = AudioObjectGetPropertyData(current_device_id, &prop_addr_name, 0, NULL, &propsize, &device_name_cf);
          propsize = sizeof(CFStringRef);
          AudioObjectPropertyAddress prop_addr_uid = {
             kAudioDevicePropertyDeviceUID,
@@ -313,7 +310,7 @@ void coreaudio_macos_microphone_free(void *data)
          if (status == noErr && device_name_cf && uid_status == noErr && device_uid_cf)
          {
             char device_name_c[256] = {0};
-            char device_uid_c[256] = {0};
+            char device_uid_c[256]  = {0};
 
             CFStringGetCString(device_name_cf, device_name_c, sizeof(device_name_c), kCFStringEncodingUTF8);
             CFStringGetCString(device_uid_cf, device_uid_c, sizeof(device_uid_c), kCFStringEncodingUTF8);
@@ -335,8 +332,10 @@ void coreaudio_macos_microphone_free(void *data)
             }
 
          }
-         if (device_name_cf) CFRelease(device_name_cf);
-         if (device_uid_cf) CFRelease(device_uid_cf);
+         if (device_name_cf)
+            CFRelease(device_name_cf);
+         if (device_uid_cf)
+            CFRelease(device_uid_cf);
       }
    }
 
@@ -943,7 +942,6 @@ static AudioDeviceID get_macos_device_id_for_uid_or_name(const char *uid_or_name
    for (UInt32 i = 0; i < num_devices; i++)
    {
       AudioDeviceID current_device_id = all_devices[i];
-      UInt32 input_stream_count = 0;
       AudioObjectPropertyAddress prop_addr_streams_input = {
          kAudioDevicePropertyStreams,
          kAudioDevicePropertyScopeInput,
@@ -984,7 +982,6 @@ static AudioDeviceID get_macos_device_id_for_uid_or_name(const char *uid_or_name
    for (UInt32 i = 0; i < num_devices; i++)
    {
       AudioDeviceID current_device_id = all_devices[i];
-      UInt32 input_stream_count = 0;
       AudioObjectPropertyAddress prop_addr_streams_input = {
          kAudioDevicePropertyStreams,
          kAudioDevicePropertyScopeInput,
diff --git a/gfx/common/vulkan_common.c b/gfx/common/vulkan_common.c
@@ -1940,8 +1940,8 @@ bool vulkan_create_swapchain(gfx_ctx_vulkan_data_t *vk,
    settings_t                    *settings = config_get_ptr();
    bool vsync                              = settings->bools.video_vsync;
    bool adaptive_vsync                     = settings->bools.video_adaptive_vsync;
-   bool video_windowed_fullscreen          = settings->bools.video_windowed_fullscreen;
 #ifdef VK_USE_PLATFORM_WIN32_KHR
+   bool video_windowed_fullscreen          = settings->bools.video_windowed_fullscreen;
    HMONITOR fse_monitor;
    VkSurfaceFullScreenExclusiveWin32InfoEXT fs_win32 = {
        VK_STRUCTURE_TYPE_SURFACE_FULL_SCREEN_EXCLUSIVE_WIN32_INFO_EXT,
@@ -2371,7 +2371,7 @@ bool vulkan_create_swapchain(gfx_ctx_vulkan_data_t *vk,
 
    if (vk->flags & VK_DATA_FLAG_EMULATING_MAILBOX)
       vulkan_emulated_mailbox_init(&vk->mailbox, vk->context.device, vk->swapchain);
-   
+
    /* This flag needs to be cleared otherwise elsewhere it can be perceived as if there's a new swapchain created everytime its being called */
    vk->flags &= ~VK_DATA_FLAG_CREATED_NEW_SWAPCHAIN;
    return true;
diff --git a/gfx/drivers/gl3.c b/gfx/drivers/gl3.c
@@ -2818,7 +2818,6 @@ static void *gl3_init(const video_info_t *video,
    gl3_t *gl                            = (gl3_t*)calloc(1, sizeof(gl3_t));
    const gfx_ctx_driver_t *ctx_driver   = gl3_get_context(gl);
    struct retro_hw_render_callback *hwr = video_driver_get_hw_context();
-   unsigned i;
 
    if (!gl || !ctx_driver)
       goto error;
@@ -3923,7 +3922,6 @@ static bool gl3_frame(void *data, const void *frame,
 
    if (gl->chain.active)
    {
-      unsigned i;
       video_shader_ctx_params_t params;
       struct video_tex_info feedback_info;
 
diff --git a/network/cloud_sync/webdav.c b/network/cloud_sync/webdav.c
@@ -128,11 +128,11 @@ static char *webdav_create_ha1_hash(char *user, char *realm, char *pass)
    char *hash = (char*)malloc(33);
 
    MD5_Init(&md5);
-   MD5_Update(&md5, user, strlen(user));
+   MD5_Update(&md5, user, (unsigned long)strlen(user));
    MD5_Update(&md5, ":", 1);
-   MD5_Update(&md5, realm, strlen(realm));
+   MD5_Update(&md5, realm, (unsigned long)strlen(realm));
    MD5_Update(&md5, ":", 1);
-   MD5_Update(&md5, pass, strlen(pass));
+   MD5_Update(&md5, pass, (unsigned long)strlen(pass));
    MD5_Final(digest, &md5);
 
    snprintf(hash, 33, "%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x",
@@ -284,9 +284,9 @@ static char *webdav_create_ha1(void)
    MD5_Init(&md5);
    MD5_Update(&md5, webdav_st->ha1hash, 32);
    MD5_Update(&md5, ":", 1);
-   MD5_Update(&md5, webdav_st->nonce, strlen(webdav_st->nonce));
+   MD5_Update(&md5, webdav_st->nonce, (unsigned long)strlen(webdav_st->nonce));
    MD5_Update(&md5, ":", 1);
-   MD5_Update(&md5, webdav_st->cnonce, strlen(webdav_st->cnonce));
+   MD5_Update(&md5, webdav_st->cnonce, (unsigned long)strlen(webdav_st->cnonce));
    MD5_Final(digest, &md5);
 
    snprintf(hash, 33, "%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x",
@@ -305,9 +305,9 @@ static char *webdav_create_ha2(const char *method, const char *path)
    char           *hash      = (char*)malloc(33);
 
    MD5_Init(&md5);
-   MD5_Update(&md5, method, strlen(method));
+   MD5_Update(&md5, method, (unsigned long)strlen(method));
    MD5_Update(&md5, ":", 1);
-   MD5_Update(&md5, path, strlen(path));
+   MD5_Update(&md5, path, (unsigned long)strlen(path));
    MD5_Final(digest, &md5);
 
    snprintf(hash, 33, "%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x",
@@ -330,15 +330,15 @@ static char *webdav_create_digest_response(const char *method, const char *path)
    MD5_Init(&md5);
    MD5_Update(&md5, ha1, 32);
    MD5_Update(&md5, ":", 1);
-   MD5_Update(&md5, webdav_st->nonce, strlen(webdav_st->nonce));
+   MD5_Update(&md5, webdav_st->nonce, (unsigned long)strlen(webdav_st->nonce));
    if (webdav_st->qop_auth)
    {
       char nonceCount[10];
       snprintf(nonceCount, sizeof(nonceCount), "%08x", webdav_st->nc);
       MD5_Update(&md5, ":", 1);
-      MD5_Update(&md5, nonceCount, strlen(nonceCount));
+      MD5_Update(&md5, nonceCount, (unsigned long)strlen(nonceCount));
       MD5_Update(&md5, ":", 1);
-      MD5_Update(&md5, webdav_st->cnonce, strlen(webdav_st->cnonce));
+      MD5_Update(&md5, webdav_st->cnonce, (unsigned long)strlen(webdav_st->cnonce));
       MD5_Update(&md5, ":", 1);
       MD5_Update(&md5, "auth", STRLEN_CONST("auth"));
    }
@@ -469,8 +469,7 @@ static bool webdav_needs_reauth(http_transfer_data_t *data)
       RARCH_DBG("[webdav] Found WWW-Authenticate: Digest header\n");
       if (webdav_create_digest_auth(data->headers->elems[i].data))
          return true;
-      else
-         RARCH_WARN("[webdav] Failure creating WWW-Authenticate: Digest header\n");
+      RARCH_WARN("[webdav] Failure creating WWW-Authenticate: Digest header\n");
    }
 
    return false;
@@ -624,7 +623,7 @@ static bool webdav_read(const char *path, const char *file,
    fill_pathname_join_special(url, webdav_st->url, path, sizeof(url));
    net_http_urlencode_full(url_encoded, url, sizeof(url_encoded));
 
-   webdav_cb_st->cb = cb;
+   webdav_cb_st->cb        = cb;
    webdav_cb_st->user_data = user_data;
    strlcpy(webdav_cb_st->path, path, sizeof(webdav_cb_st->path));
    strlcpy(webdav_cb_st->file, file, sizeof(webdav_cb_st->file));
@@ -672,7 +671,7 @@ static void webdav_mkdir_cb(retro_task_t *task, void *task_data,
    webdav_mkdir_st->last_slash = strchr(webdav_mkdir_st->last_slash + 1, '/');
    if (webdav_mkdir_st->last_slash)
    {
-      webdav_mkdir_st->post_slash = webdav_mkdir_st->last_slash[1];
+      webdav_mkdir_st->post_slash    = webdav_mkdir_st->last_slash[1];
       webdav_mkdir_st->last_slash[1] = '\0';
       RARCH_DBG("[webdav] MKCOL %s\n", webdav_mkdir_st->url);
       auth_header = webdav_get_auth_header("MKCOL", webdav_mkdir_st->url);
@@ -690,17 +689,17 @@ static void webdav_mkdir_cb(retro_task_t *task, void *task_data,
 static void webdav_ensure_dir(const char *dir, webdav_mkdir_cb_t cb,
       webdav_cb_state_t *webdav_cb_st)
 {
+   char url[PATH_MAX_LENGTH];
    http_transfer_data_t  data;
    webdav_state_t       *webdav_st       = webdav_state_get_ptr();
    webdav_mkdir_state_t *webdav_mkdir_st = (webdav_mkdir_state_t *)malloc(sizeof(webdav_mkdir_state_t));
-   char                  url[PATH_MAX_LENGTH];
 
    fill_pathname_join_special(url, webdav_st->url, dir, sizeof(url));
    net_http_urlencode_full(webdav_mkdir_st->url, url, sizeof(webdav_mkdir_st->url));
    webdav_mkdir_st->last_slash = strchr(webdav_mkdir_st->url + strlen(webdav_st->url) - 1, '/');
    webdav_mkdir_st->post_slash = webdav_mkdir_st->last_slash[1];
-   webdav_mkdir_st->cb = cb;
-   webdav_mkdir_st->cb_st = webdav_cb_st;
+   webdav_mkdir_st->cb         = cb;
+   webdav_mkdir_st->cb_st      = webdav_cb_st;
 
    /* this is a recursive callback, set it up so it looks like it's still proceeding */
    data.status = 200;
@@ -775,8 +774,8 @@ static void webdav_do_update(bool success, webdav_cb_state_t *webdav_cb_st)
 static bool webdav_update(const char *path, RFILE *rfile,
       cloud_sync_complete_handler_t cb, void *user_data)
 {
-   webdav_cb_state_t *webdav_cb_st = (webdav_cb_state_t*)calloc(1, sizeof(webdav_cb_state_t));
    char               dir[DIR_MAX_LENGTH];
+   webdav_cb_state_t *webdav_cb_st = (webdav_cb_state_t*)calloc(1, sizeof(webdav_cb_state_t));
 
    /* TODO/FIXME: if !settings->bools.cloud_sync_destructive, should move to deleted/ first */
 
