Merge pull request #959 from fractal-analytics-platform/958_apply_registration_fix

Allow apply acquisition to find the reference better

Author: jluethi

CHANGELOG.md

@@ -1,5 +1,9 @@
 **Note**: Numbers like (\#123) point to closed Pull Requests on the fractal-tasks-core repository.
 
+# 1.5.3
+* Tasks:
+    * Fix the heuristic in the Apply registration task to handle the registration of the reference cycle better (\#959).
+
 # 1.5.2
 * Library
     * Update masked loading wrapper to support loading masking ROIs written by ngio (\#957).

fractal_tasks_core/tasks/_zarr_utils.py

@@ -140,10 +140,6 @@ def _get_matching_ref_acquisition_path_heuristic(
     # Sort path_list
     sorted_path_list = sorted(path_list)
 
-    # Never return the input `path`
-    if path in sorted_path_list:
-        sorted_path_list.remove(path)
-
     # First matching rule: a path with the same suffix
     for p in sorted_path_list:
         # Split the list path into base and suffix

tests/tasks/test_unit_zarr_utils.py

@@ -184,6 +184,7 @@ def test_update_well_metadata_failures(
 
 HEURISTIC_CASES = [
     (["0", "0_illum_corr"], "1_illum_corr", "0_illum_corr"),
+    (["0", "0_illum_corr"], "0_illum_corr", "0_illum_corr"),
     (["0", "0_illum_corr"], "1", "0"),
     (["0", "0_illum_corr", "0_registered"], "1_illum_corr", "0_illum_corr"),
     (["0", "1", "2", "3"], "0_acq2", "0"),