Skip to content

Commit d98acd0

Browse files
authored
Merge pull request #943 from fractal-analytics-platform/ngio-023
Require ngio 0.2.3
2 parents dd2b916 + c42d6ac commit d98acd0

File tree

5 files changed

+482
-364
lines changed

5 files changed

+482
-364
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# 1.5.0 (a2 prerelease)
44

55
* Dependencies:
6-
* Bump `ngio` to `>=0.2.2,<0.3.0`.
6+
* Bump `ngio` to `>=0.2.4,<0.3.0`.
77
* Tasks:
88
* Refactor `projection` task to use the new `ngio` API.
99
* Refactor `copy_ome_zarr_plate` init task to support the upcoming flexibility.

fractal_tasks_core/tasks/projection.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,16 +121,11 @@ def projection(
121121
roi_table_name, check_type="generic_roi_table"
122122
)
123123

124-
roi_list = []
125124
for roi in table.rois():
126125
roi.z = 0.0
127126
roi.z_length = 1.0
128-
roi_list.append(roi)
127+
table.add(roi, overwrite=True)
129128

130-
# We should have a public API to set reset the rois
131-
# or have a overwrite keyword in the add method
132-
table._rois = {}
133-
table.add(roi_list)
134129
table.consolidate()
135130
logger.info(f"Table {roi_table_name} Projection done")
136131

0 commit comments

Comments
 (0)