Improved logging of error responses from fractal-server in SSR

Author: zonia3000

src/hooks.server.js

@@ -1,7 +1,7 @@
 import { env } from '$env/dynamic/private';
+import { formatDate, getLogger } from '$lib/server/logger.js';
 import { getServerInfo } from '$lib/server/api/alive';
 import { getCurrentUser } from '$lib/server/api/auth_api';
-import { getLogger } from '$lib/server/logger.js';
 import { error, redirect } from '@sveltejs/kit';
 
 const logger = getLogger('hooks');
@@ -113,7 +113,17 @@ export async function handleFetch({ event, request, fetch }) {
 			request.headers.set('cookie', cookie);
 		}
 	}
-	return fetch(request);
+	const startTime = new Date();
+	const response = await fetch(request);
+	if (!response.ok) {
+		logger.error(
+			'Error response from %s - Status=%d - Start Time=%s',
+			request.url,
+			response.status,
+			formatDate(startTime)
+		);
+	}
+	return response;
 }
 
 /**

src/lib/common/errors.js

@@ -1,20 +1,7 @@
-import { error } from '@sveltejs/kit';
 import StandardErrorAlert from '$lib/components/common/StandardErrorAlert.svelte';
 import { writable } from 'svelte/store';
 import { mount } from 'svelte';
 
-/**
- * Propagates an error response.
- * @param {Response} response
- */
-export async function responseError(response) {
-	let errorResponse = await response.json();
-	if ('detail' in errorResponse) {
-		errorResponse = errorResponse.detail;
-	}
-	error(response.status, errorResponse);
-}
-
 /**
  * @param {Response} response
  */

src/lib/common/errors.server.js

@@ -0,0 +1,22 @@
+import { getLogger } from '$lib/server/logger';
+import { error } from '@sveltejs/kit';
+
+const logger = getLogger('errors');
+
+/**
+ * Propagates an error response.
+ * @param {Response} response
+ */
+export async function responseError(response) {
+	let errorResponse;
+	if (response.status === 500) {
+		errorResponse = response.statusText;
+	} else {
+		errorResponse = await response.json();
+		logger.debug('Error response body: %s', errorResponse);
+		if ('detail' in errorResponse) {
+			errorResponse = errorResponse.detail;
+		}
+	}
+	error(response.status, errorResponse);
+}

src/lib/server/api/auth_api.js

@@ -1,5 +1,5 @@
 import { env } from '$env/dynamic/private';
-import { responseError } from '$lib/common/errors';
+import { responseError } from '$lib/common/errors.server';
 import { getLogger } from '$lib/server/logger.js';
 
 const logger = getLogger('auth API');

src/lib/server/api/v2/admin_api.js

@@ -1,5 +1,5 @@
 import { env } from '$env/dynamic/private';
-import { responseError } from '$lib/common/errors';
+import { responseError } from '$lib/common/errors.server';
 import { getLogger } from '$lib/server/logger.js';
 
 const logger = getLogger('admin API [v2]');

src/lib/server/api/v2/dataset_api.js

@@ -1,5 +1,5 @@
 import { env } from '$env/dynamic/private';
-import { responseError } from '$lib/common/errors';
+import { responseError } from '$lib/common/errors.server';
 import { getLogger } from '$lib/server/logger.js';
 import { normalizePayload } from 'fractal-components';
 

src/lib/server/api/v2/project_api.js

@@ -1,5 +1,5 @@
 import { env } from '$env/dynamic/private';
-import { responseError } from '$lib/common/errors';
+import { responseError } from '$lib/common/errors.server';
 import { getLogger } from '$lib/server/logger.js';
 
 const logger = getLogger('projects API [v2]');

src/lib/server/api/v2/settings_api.js

@@ -1,5 +1,5 @@
 import { env } from '$env/dynamic/private';
-import { responseError } from '$lib/common/errors';
+import { responseError } from '$lib/common/errors.server';
 import { getLogger } from '$lib/server/logger.js';
 
 const logger = getLogger('settings API');

src/lib/server/api/v2/task_api.js

@@ -1,5 +1,5 @@
 import { env } from '$env/dynamic/private';
-import { responseError } from '$lib/common/errors.js';
+import { responseError } from '$lib/common/errors.server';
 import { getLogger } from '$lib/server/logger.js';
 
 const logger = getLogger('task API [v2]');

src/lib/server/api/v2/workflow_api.js

@@ -1,5 +1,5 @@
 import { env } from '$env/dynamic/private';
-import { responseError } from '$lib/common/errors';
+import { responseError } from '$lib/common/errors.server';
 import { getLogger } from '$lib/server/logger.js';
 
 const logger = getLogger('workflow API [v2]');