Skip to content

Commit 0d49ca4

Browse files
committed
Displayed workflow params sections only for compound tasks having both parallel and non parallel params
1 parent 11b2352 commit 0d49ca4

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/lib/components/v2/workflow/ArgumentsSchema.svelte

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,15 @@
131131
return argsSchemaVersion && SUPPORTED_SCHEMA_VERSIONS.includes(argsSchemaVersion);
132132
}
133133
134-
$: showNonParallelTitle =
134+
$: hasNonParallelArgs =
135135
!workflowTask.is_legacy_task &&
136136
workflowTask.task.args_schema_non_parallel &&
137137
Object.keys(
138138
stripSchemaProperties(workflowTask.task.args_schema_non_parallel, workflowTask.is_legacy_task)
139139
.properties
140140
).length;
141141
142-
$: showParallelTitle =
142+
$: hasParallelArgs =
143143
argsSchemaParallel &&
144144
Object.keys(stripSchemaProperties(argsSchemaParallel, workflowTask.is_legacy_task).properties)
145145
.length;
@@ -148,7 +148,7 @@
148148
<div id="workflow-arguments-schema-panel">
149149
<div id="json-schema-validation-errors" />
150150
{#if workflowTask.task_type === 'non_parallel' || workflowTask.task_type === 'compound'}
151-
{#if showNonParallelTitle}
151+
{#if hasNonParallelArgs && hasParallelArgs}
152152
<h5 class="ps-2 mt-3">Initialisation Parameters</h5>
153153
{/if}
154154
{#if !workflowTask.is_legacy_task && workflowTask.task.args_schema_non_parallel && isSchemaValid}
@@ -171,11 +171,11 @@
171171
</div>
172172
{/if}
173173
{/if}
174-
{#if workflowTask.task_type === 'compound' && showParallelTitle}
174+
{#if hasNonParallelArgs && hasParallelArgs}
175175
<hr />
176176
{/if}
177177
{#if workflowTask.task_type === 'parallel' || workflowTask.task_type === 'compound'}
178-
{#if showParallelTitle}
178+
{#if hasParallelArgs && hasNonParallelArgs}
179179
<h5 class="ps-2 mt-3">Compute Parameters</h5>
180180
{/if}
181181
{#if argsSchemaParallel && isSchemaValid}
@@ -198,7 +198,7 @@
198198
</div>
199199
{/if}
200200
{/if}
201-
{#if !showNonParallelTitle && !showParallelTitle}
201+
{#if !hasNonParallelArgs && !hasParallelArgs}
202202
<p class="mt-3 ps-3">No arguments</p>
203203
{/if}
204204
<div class="d-flex jschema-controls-bar p-3">

0 commit comments

Comments
 (0)