Skip to content

Commit 164de22

Browse files
committed
Fixed input filters lost after version update
1 parent 7d85c30 commit 164de22

File tree

3 files changed

+21
-1
lines changed

3 files changed

+21
-1
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@
5454
],
5555
"bundleDependencies": [
5656
"@vincjo/datatables",
57-
"ajv",
57+
"ajv/dist/ajv",
58+
"ajv/dist/2020",
5859
"ajv-formats",
5960
"dompurify",
6061
"jose",

src/lib/components/v2/workflow/VersionUpdate.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@
173173
order: workflowTask.order,
174174
meta_non_parallel: workflowTask.meta_non_parallel,
175175
meta_parallel: workflowTask.meta_parallel,
176+
input_filters: workflowTask.input_filters,
176177
args_non_parallel:
177178
fixArgsComponentNonParallel?.getNewArgs() || workflowTask.args_non_parallel,
178179
args_parallel: fixArgsComponentParallel?.getNewArgs() || workflowTask.args_parallel,

tests/v2/task_version_update.spec.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,17 @@ test('Task version update [v2]', async ({ page, workflow }) => {
124124
await page.getByText('Arguments changes saved successfully').waitFor();
125125
});
126126

127+
await test.step('Add Input Filters', async () => {
128+
await page.getByText('Input Filters').click();
129+
await page.getByRole('button', { name: 'Add attribute filter', exact: true }).click();
130+
await page.getByPlaceholder('Key').fill('key1');
131+
await page.getByPlaceholder('Value').fill('value1');
132+
await page.getByRole('button', { name: 'Add type filter', exact: true }).click();
133+
await page.getByPlaceholder('Key').nth(1).fill('key2');
134+
await page.getByRole('button', { name: 'Save' }).click();
135+
await page.getByText('Input filters successfully updated').waitFor();
136+
});
137+
127138
await test.step('Update non parallel task to v2', async () => {
128139
await page.getByRole('button', { name: 'Version' }).click();
129140
await page
@@ -138,6 +149,13 @@ test('Task version update [v2]', async ({ page, workflow }) => {
138149
await page.getByText('The arguments are valid').waitFor();
139150
await page.getByRole('button', { name: 'Update' }).click();
140151
await page.getByText('No new versions available').waitFor();
152+
});
153+
154+
await test.step('Verify that input filters have been preserved', async () => {
155+
await page.getByText('Input Filters').click();
156+
await expect(page.getByPlaceholder('Key').first()).toHaveValue('key1');
157+
await expect(page.getByPlaceholder('Value')).toHaveValue('value1');
158+
await expect(page.getByPlaceholder('Key').nth(1)).toHaveValue('key2');
141159
await workflow.removeCurrentTask();
142160
});
143161

0 commit comments

Comments
 (0)