Skip to content

Commit 170714f

Browse files
committed
Fix: Show dataset meta props in modal
Handle the case as described in #126 - Minor fixes in layout to align with other pages Closes #126
1 parent b9f3c5b commit 170714f

File tree

1 file changed

+34
-16
lines changed

1 file changed

+34
-16
lines changed

src/routes/projects/[id]/datasets/[datasetId]/+page.svelte

Lines changed: 34 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,14 @@
111111
{/if}
112112
</ol>
113113
</nav>
114+
<div>
115+
{#if dataset && Object.keys(dataset.meta).length > 0 }
116+
<button class="btn btn-light" data-bs-target="#datasetMetaModal" data-bs-toggle="modal"><i class="bi-arrow-up-right-square"></i> Show meta properties</button>
117+
{/if}
118+
{#if dataset}
119+
<button class="btn btn-light" data-bs-toggle="modal" data-bs-target="#updateDatasetModal"><i class="bi-gear-wide-connected"></i></button>
120+
{/if}
121+
</div>
114122
</div>
115123

116124
{#if dataset}
@@ -124,8 +132,6 @@
124132
<div class="col-4">
125133
<div class="d-flex align-items-center justify-content-between">
126134
<span class="lead py-3">Dataset properties</span>
127-
<a href="#" class="btn btn-secondary btn-sm" data-bs-toggle="modal" data-bs-target="#updateDatasetModal">Edit
128-
dataset</a>
129135
</div>
130136
<ul class="list-group">
131137
<li class="list-group-item text-bg-light">
@@ -153,19 +159,6 @@
153159
<span class="badge bg-info">{dataset.read_only}</span>
154160
</li>
155161
</ul>
156-
{#if Object.keys(dataset.meta).length > 0 }
157-
<p class="text-muted mt-3">Meta properties</p>
158-
<ul class="list-group">
159-
{#each Object.entries(dataset.meta) as [key, value] }
160-
<li class="list-group-item text-bg-light">
161-
<span class="text-capitalize">{key}</span>
162-
</li>
163-
<li class="list-group-item">
164-
<span class="">{value}</span>
165-
</li>
166-
{/each}
167-
</ul>
168-
{/if}
169162
</div>
170163
<div class="col-8">
171164
<div class="d-flex align-items-center justify-content-between">
@@ -276,4 +269,29 @@
276269
</div>
277270
</div>
278271
</div>
279-
{/if}
272+
{/if}
273+
274+
{#if dataset && Object.keys(dataset.meta).length > 0 }
275+
<div class="modal" id="datasetMetaModal">
276+
<div class="modal-dialog modal-dialog-centered modal-dialog-scrollable modal-lg">
277+
<div class="modal-content">
278+
<div class="modal-header">
279+
<h5 class="modal-title">Dataset meta properties</h5>
280+
<button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
281+
</div>
282+
<div class="modal-body">
283+
<ul class="list-group">
284+
{#each Object.entries(dataset.meta) as [key, value] }
285+
<li class="list-group-item text-bg-light">
286+
<span class="text-capitalize">{key}</span>
287+
</li>
288+
<li class="list-group-item text-break">
289+
<span class="">{value}</span>
290+
</li>
291+
{/each}
292+
</ul>
293+
</div>
294+
</div>
295+
</div>
296+
</div>
297+
{/if}

0 commit comments

Comments
 (0)