Skip to content

Commit 18ea0e5

Browse files
committed
Removed function and button to save dataset filters
1 parent 4450db5 commit 18ea0e5

File tree

3 files changed

+0
-46
lines changed

3 files changed

+0
-46
lines changed

src/lib/components/v2/projects/datasets/DatasetImagesTable.svelte

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@
2323
/** @type {{ attribute_filters: { [key: string]: Array<string | number | boolean> | null }, type_filters: { [key: string]: boolean | null }} | null} */
2424
export let initialFilterValues = null;
2525
26-
/** @type {(dataset: import('fractal-components/types/api').DatasetV2) => void} */
27-
export let onDatasetsUpdated = () => {};
28-
2926
let showTable = false;
3027
let firstLoad = true;
3128
@@ -34,7 +31,6 @@
3431
3532
let searching = false;
3633
let resetting = false;
37-
let savingDatasetFilters = false;
3834
3935
/** @type {{ [key: string]: Array<string | number | boolean> | null}} */
4036
let attributeFilters = {};
@@ -520,33 +516,6 @@
520516
}
521517
return false;
522518
}
523-
524-
async function saveDatasetFilters() {
525-
errorAlert?.hide();
526-
savingDatasetFilters = true;
527-
const headers = new Headers();
528-
headers.set('Content-Type', 'application/json');
529-
const response = await fetch(`/api/v2/project/${dataset.project_id}/dataset/${dataset.id}`, {
530-
method: 'PATCH',
531-
credentials: 'include',
532-
headers,
533-
body: JSON.stringify({
534-
attribute_filters: getAttributeFilters(),
535-
type_filters: getTypeFilters()
536-
})
537-
});
538-
if (response.ok) {
539-
const result = await response.json();
540-
dataset = result;
541-
onDatasetsUpdated(dataset);
542-
} else {
543-
errorAlert = displayStandardErrorAlert(
544-
await getAlertErrorFromResponse(response),
545-
'datasetImagesError'
546-
);
547-
}
548-
savingDatasetFilters = false;
549-
}
550519
</script>
551520
552521
{#if !showTable}
@@ -650,17 +619,6 @@
650619
{/if}
651620
Reset
652621
</button>
653-
{#if !runWorkflowModal}
654-
<ConfirmActionButton
655-
modalId="confirmSaveDatasetFilters"
656-
label="Save"
657-
message="Save dataset filters"
658-
disabled={savingDatasetFilters}
659-
callbackAction={async () => {
660-
await saveDatasetFilters();
661-
}}
662-
/>
663-
{/if}
664622
</th>
665623
</tr>
666624
</thead>

src/lib/components/v2/projects/datasets/DatasetInfoModal.svelte

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,9 +212,6 @@
212212
</span>
213213
{/if}
214214
</li>
215-
<li class="list-group-item text-bg-light">
216-
<strong>Dataset filters</strong>
217-
</li>
218215
</ul>
219216
</svelte:fragment>
220217
</Modal>

src/routes/v2/projects/[projectId]/datasets/[datasetId]/+page.svelte

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,6 @@
207207
{vizarrViewerUrl}
208208
runWorkflowModal={false}
209209
bind:this={imagesTable}
210-
onDatasetsUpdated={(updated) => (dataset = updated)}
211210
/>
212211

213212
<DatasetInfoModal {dataset} updateDatasetCallback={(d) => (dataset = d)} />

0 commit comments

Comments
 (0)