Test fixes

Author: zonia3000

src/lib/common/errors.js

@@ -1,7 +1,7 @@
 import { error } from '@sveltejs/kit';
 import StandardErrorAlert from '$lib/components/common/StandardErrorAlert.svelte';
 import { writable } from 'svelte/store';
-import { mount } from "svelte";
+import { mount } from 'svelte';
 
 /**
  * Propagates an error response.
@@ -208,11 +208,11 @@ export function displayStandardErrorAlert(error, targetElementId) {
 	const errorAlert = document.getElementById(targetElementId);
 	if (errorAlert) {
 		return mount(StandardErrorAlert, {
-        			target: errorAlert,
-        			props: {
-        				error
-        			}
-        		});
+			target: errorAlert,
+			props: {
+				error
+			}
+		});
 	} else {
 		console.warn(`Unable to display the error: element ${targetElementId} not found`);
 	}

src/lib/components/common/StandardErrorAlert.svelte

@@ -8,7 +8,7 @@
 	 */
 
 	/** @type {Props} */
-	let { error, children } = $props();
+	let { error, children = undefined } = $props();
 
 	const errorData = $derived(getErrorData(error));
 

tests/settings.spec.js

@@ -35,7 +35,7 @@ test('User settings', async ({ page }) => {
 		await page.getByLabel('SLURM account 1').fill(randomSlurmAccount);
 		await page.getByLabel('SLURM account 2').fill(randomSlurmAccount);
 		await page.getByRole('button', { name: 'Save' }).click();
-		await page.getByText('`slurm_accounts` list has repetitions').waitFor();
+		await page.getByText('List has repetitions').waitFor();
 	});
 
 	await test.step('Add SLURM account (success)', async () => {

tests/v2/custom_env_task.spec.js

@@ -46,7 +46,9 @@ test('Custom Python env task [v2]', async ({ page }) => {
 
 		await page.getByRole('button', { name: 'Collect' }).click();
 
-		await expect(page.getByText('Python interpreter path must be absolute')).toBeVisible();
+		await expect(
+			page.getByText("Value error, String must be an absolute path (given 'foo')")
+		).toBeVisible();
 	});
 
 	await test.step("Test \"One and only one must be set between 'package_root' and 'package_name'\" error", async () => {

tests/v2/users_crud.spec.js

@@ -93,18 +93,9 @@ test('Create and update a user', async ({ page }) => {
 	await test.step('Test project dir validation error', async () => {
 		await page.getByLabel('Project dir').fill('foo');
 		await page.getByRole('button', { name: 'Save' }).click();
-		await page.waitForFunction(() => {
-			const invalidFeeback = document
-				.querySelector('#projectDir')
-				?.closest('div')
-				?.querySelector('.invalid-feedback');
-			if (invalidFeeback instanceof HTMLElement) {
-				return invalidFeeback.innerText.includes(
-					"String attribute 'project_dir' must be an absolute path (given 'foo')"
-				);
-			}
-			return false;
-		});
+		await expect(
+			page.getByText("Value error, String must be an absolute path (given 'foo')")
+		).toBeVisible();
 		await page.getByLabel('Project dir').fill('/tmp/test/project-dir');
 	});
 
@@ -118,7 +109,7 @@ test('Create and update a user', async ({ page }) => {
 			.getByRole('textbox', { name: /^SLURM account #2/ })
 			.fill(randomUserName + '-slurm-account');
 		await page.getByRole('button', { name: 'Save' }).click();
-		await page.getByText('`slurm_accounts` list has repetitions').waitFor();
+		await expect(page.getByText('Value error, List has repetitions')).toBeVisible();
 		await page.getByLabel('Remove SLURM account').first().click();
 	});
 

tests/v2/viewer_paths.spec.js

@@ -54,9 +54,7 @@ test('Viewer paths', async ({ page }) => {
 		await addViewerPathBtn.click();
 		const saveBtn = page.getByRole('button', { name: 'Save' }).first();
 		await saveBtn.click();
-		await expect(
-			page.getByText("String attribute 'viewer_paths[0]' cannot be empty")
-		).toBeVisible();
+		await expect(page.getByText('String should have at least 1 character')).toBeVisible();
 		await page.getByLabel('Viewer path #1', { exact: true }).fill('/path/to/1');
 		await page.getByLabel('Viewer path #2', { exact: true }).fill('/path/to/2');
 		await saveBtn.click();