Removed ENABLE_INTERACTIVE_FILTERS environment variable

Author: zonia3000

.env

@@ -20,6 +20,5 @@ LOG_LEVEL_CONSOLE=warn
 
 FRACTAL_RUNNER_BACKEND=local
 #WARNING_BANNER_PATH=/path/to/banner.txt
-ENABLE_INTERACTIVE_FILTERS=false
 
 BODY_SIZE_LIMIT=5000000

.env.development

@@ -19,4 +19,3 @@ LOG_LEVEL_CONSOLE=info
 
 FRACTAL_RUNNER_BACKEND=local
 #WARNING_BANNER_PATH=/path/to/banner.txt
-ENABLE_INTERACTIVE_FILTERS=false

.github/workflows/end_to_end_tests.yaml

@@ -19,7 +19,6 @@ jobs:
       OAUTH_DEXIDP_OIDC_CONFIGURATION_ENDPOINT: "http://127.0.0.1:5556/dex/.well-known/openid-configuration"
       PUBLIC_OAUTH_CLIENT_NAME: dexidp
       PUBLIC_FRACTAL_VIZARR_VIEWER_URL: http://localhost:3000/vizarr
-      ENABLE_INTERACTIVE_FILTERS: true
 
     strategy:
       matrix:

__tests__/v2/RunWorkflowModal.test.js

@@ -67,8 +67,7 @@ describe('RunWorkflowModal', () => {
 					num_failed_images: 5,
 					num_available_images: 5
 				}
-			},
-			filtersEnabled: false
+			}
 		});
 
 		result.component.open('continue');

docs/environment-variables.md

@@ -19,7 +19,6 @@ The following environment variables can be used to configure fractal-web.
 * `FRACTAL_RUNNER_BACKEND`: specifies which runner backend is used; supported values are: `local`, `slurm`, `slurm_ssh`; setting this variable is mandatory;
 * `PUBLIC_FRACTAL_VIZARR_VIEWER_URL`: URL to [fractal-vizarr-viewer](https://github.com/fractal-analytics-platform/fractal-vizarr-viewer) service (e.g. http://localhost:3000/vizarr for testing);
 * `WARNING_BANNER_PATH`: specifies the path to a text file containing the warning banner message displayed on the site; the banner is used to inform users about important issues, such as external resources downtime or maintenance alerts; if the variable is empty or unset no banner is displayed;
-* `ENABLE_INTERACTIVE_FILTERS`: enable attribute and type filters interactive editing from the job-submission modal; supported values are `true` or `false`; default value is `false`.
 
 When running directly using `node` command these extra variables can also be configured:
 

docs/quickstart.md

@@ -66,7 +66,6 @@ export FRACTAL_RUNNER_BACKEND=local
 #export AUTH_COOKIE_PATH=/
 #export AUTH_COOKIE_SAME_SITE=lax
 #export PUBLIC_UPDATE_JOBS_INTERVAL=3000
-#export ENABLE_INTERACTIVE_FILTERS=false
 
 node build/
 ```

src/lib/components/v2/projects/datasets/DatasetImagesTable.svelte

@@ -20,7 +20,6 @@
 	 * @type {boolean}
 	 */
 	export let runWorkflowModal;
-	export let filtersEnabled = true;
 	/** @type {{ attribute_filters: { [key: string]: Array<string | number | boolean> | null }, type_filters: { [key: string]: boolean | null }} | null} */
 	export let initialFilterValues = null;
 
@@ -208,17 +207,6 @@
 				)
 			])
 		);
-
-		if (runWorkflowModal && !filtersEnabled) {
-			// disable attribute filters selection
-			for (const attributeSelector of Object.values(attributesSelectors)) {
-				attributeSelector.disable();
-			}
-			// disable type filters selection
-			for (const typeSelector of Object.values(typesSelectors)) {
-				typeSelector.disable();
-			}
-		}
 	}
 
 	/**

src/lib/components/v2/workflow/RunWorkflowModal.svelte

@@ -23,7 +23,6 @@
 	export let onDatasetsUpdated;
 	/** @type {{[key: number]: import('fractal-components/types/api').ImagesStatus}} */
 	export let statuses;
-	export let filtersEnabled;
 
 	/** @type {Modal} */
 	let modal;
@@ -611,7 +610,6 @@
 										dataset={selectedDataset}
 										bind:imagePage
 										{initialFilterValues}
-										{filtersEnabled}
 										vizarrViewerUrl={null}
 										runWorkflowModal={true}
 									/>

src/routes/v2/projects/[projectId]/workflows/[workflowId]/+page.server.js

@@ -3,7 +3,6 @@ import { getProjectDatasets } from '$lib/server/api/v2/project_api';
 import { getDefaultWorkflowDataset } from '$lib/common/workflow_utilities';
 import { getLogger } from '$lib/server/logger.js';
 import { getCurrentUser } from '$lib/server/api/auth_api';
-import { env } from '$env/dynamic/private';
 
 const logger = getLogger('workflow page [v2]');
 
@@ -22,13 +21,10 @@ export async function load({ fetch, params }) {
 
 	const defaultDatasetId = getDefaultWorkflowDataset(datasets, jobs);
 
-	const filtersEnabled = env.ENABLE_INTERACTIVE_FILTERS === 'true';
-
 	return {
 		workflow,
 		datasets,
 		defaultDatasetId,
-		user,
-		filtersEnabled
+		user
 	};
 }

src/routes/v2/projects/[projectId]/workflows/[workflowId]/+page.svelte

@@ -34,7 +34,6 @@
 	$: project = workflow.project;
 	/** @type {import('fractal-components/types/api').DatasetV2[]} */
 	let datasets = $page.data.datasets;
-	let filtersEnabled = $page.data.filtersEnabled;
 
 	/** @type {number|undefined} */
 	let selectedDatasetId = undefined;
@@ -1142,7 +1141,6 @@
 	{selectedDatasetId}
 	{onJobSubmitted}
 	{statuses}
-	{filtersEnabled}
 	onDatasetsUpdated={(updatedDatasets, newSelectedDatasetId) => {
 		datasets = updatedDatasets;
 		selectedDatasetId = newSelectedDatasetId;