Skip to content

Commit 5dc0c15

Browse files
committed
Minor fix on validation error
1 parent dbcd469 commit 5dc0c15

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

src/lib/components/v2/tasks/CustomEnvTask.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@
8686
8787
collecting = true;
8888
errorAlert?.hide();
89+
validationErrors = {};
8990
successMessage = '';
9091
try {
9192
const body = {

tests/v2/custom_env_task.spec.js

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,9 @@ test('Custom Python env task [v2]', async ({ page }) => {
2929
fs.mkdirSync(packageFolder);
3030

3131
let tmpManifest;
32-
await test.step('Fill all the fields to trigger the validation error', async () => {
33-
await page.getByRole('textbox', { name: 'Python Intepreter' }).fill('/usr/bin/python3');
32+
33+
await test.step('Test "Python interpreter path must be absolute" error', async () => {
34+
await page.getByRole('textbox', { name: 'Python Intepreter' }).fill('foo');
3435
await page.getByRole('textbox', { name: 'Source' }).fill(`${randomName}-source`);
3536
tmpManifest = await uploadFile(
3637
page,
@@ -39,12 +40,21 @@ test('Custom Python env task [v2]', async ({ page }) => {
3940
manifestData,
4041
packageFolder
4142
);
42-
await page.getByRole('textbox', { name: 'Package Name' }).fill(randomName);
4343
await page.getByRole('textbox', { name: 'Version' }).fill('0.0.1');
4444
await page.getByRole('textbox', { name: 'Package Folder' }).fill(packageFolder);
4545

4646
await page.getByRole('button', { name: 'Collect' }).click();
4747

48+
await expect(page.getByText('Python interpreter path must be absolute')).toBeVisible();
49+
});
50+
51+
await test.step("Test \"One and only one must be set between 'package_root' and 'package_name'\" error", async () => {
52+
await page.getByRole('textbox', { name: 'Python Intepreter' }).fill('/usr/bin/python3');
53+
await page.getByRole('textbox', { name: 'Package Name' }).fill(randomName);
54+
55+
await page.getByRole('button', { name: 'Collect' }).click();
56+
57+
await expect(page.getByText('Python interpreter path must be absolute')).not.toBeVisible();
4858
await expect(
4959
page.getByText("One and only one must be set between 'package_root' and 'package_name'")
5060
).toBeVisible();
@@ -54,6 +64,9 @@ test('Custom Python env task [v2]', async ({ page }) => {
5464
await page.getByRole('textbox', { name: 'Package Name' }).clear();
5565
await page.getByRole('button', { name: 'Collect' }).click();
5666
await expect(page.getByText('Tasks collected successfully')).toBeVisible();
67+
await expect(
68+
page.getByText("One and only one must be set between 'package_root' and 'package_name'")
69+
).not.toBeVisible();
5770
});
5871

5972
await test.step('Verify that fields have been cleaned', async () => {

0 commit comments

Comments
 (0)