Skip to content

Commit 609452f

Browse files
committed
Clean up github actions in view of improved testing
1 parent d3ed833 commit 609452f

File tree

3 files changed

+70
-7
lines changed

3 files changed

+70
-7
lines changed
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
name: End-to-end tests
2+
3+
on:
4+
push:
5+
branches: ['main']
6+
pull_request:
7+
branches: ['main']
8+
9+
jobs:
10+
end_to_end_tests:
11+
name: 'Node ${{ matrix.node-version }}'
12+
runs-on: ubuntu-20.04
13+
timeout-minutes: 10
14+
15+
strategy:
16+
matrix:
17+
node-version: ['16', '18', '20']
18+
19+
steps:
20+
- name: Check out repo
21+
uses: actions/checkout@v4
22+
23+
- name: Set up node
24+
uses: actions/setup-node@v3
25+
with:
26+
node-version: ${{ matrix.node-version }}
27+
cache: npm
28+
29+
- name: Install dependencies
30+
run: npm install
31+
32+
- name: Run playwright tests (not implemented)
33+
run: echo "Not implemented"

.github/workflows/check_and_build.yaml renamed to .github/workflows/lint_and_build.yaml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Check&Build
1+
name: Lint and build
22

33
on:
44
push:
@@ -7,18 +7,18 @@ on:
77
branches: ['main']
88

99
jobs:
10-
check_and_build:
10+
lint_and_build:
1111
name: 'Node ${{ matrix.node-version }}'
1212
runs-on: ubuntu-20.04
1313
timeout-minutes: 10
1414

1515
strategy:
1616
matrix:
17-
node-version: ['16', '18']
17+
node-version: ['16', '18', '20']
1818

1919
steps:
2020
- name: Check out repo
21-
uses: actions/checkout@v3
21+
uses: actions/checkout@v4
2222

2323
- name: Set up node
2424
uses: actions/setup-node@v3
@@ -32,9 +32,6 @@ jobs:
3232
- name: Run static code analysis
3333
run: npx eslint .
3434

35-
- name: Run vitest tests
36-
run: npm run test
37-
3835
- name: Build site
3936
env:
4037
FRACTAL_SERVER_HOST: http://localhost:8000

.github/workflows/unit_tests.yaml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
name: Unit tests
2+
3+
on:
4+
push:
5+
branches: ['main']
6+
pull_request:
7+
branches: ['main']
8+
9+
jobs:
10+
unit_tests:
11+
name: 'Node ${{ matrix.node-version }}'
12+
runs-on: ubuntu-20.04
13+
timeout-minutes: 10
14+
15+
strategy:
16+
matrix:
17+
node-version: ['16', '18', '20']
18+
19+
steps:
20+
- name: Check out repo
21+
uses: actions/checkout@v4
22+
23+
- name: Set up node
24+
uses: actions/setup-node@v3
25+
with:
26+
node-version: ${{ matrix.node-version }}
27+
cache: npm
28+
29+
- name: Install dependencies
30+
run: npm install
31+
32+
- name: Run vitest tests
33+
run: npm run test

0 commit comments

Comments
 (0)