Skip to content

Commit 617e10a

Browse files
committed
Minor change on test
1 parent 1c4c917 commit 617e10a

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

tests/users_crud.spec.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ test('Create, update and delete a user', async ({ page }) => {
2424
await page.getByRole('button', { name: 'Save' }).click();
2525
expect(await page.getByText('Field is required').count()).toEqual(2);
2626

27-
await page.locator('#email').fill(randomUserName + '@example.com');
28-
await page.locator('#username').fill(randomUserName);
27+
await page.getByLabel('E-mail').fill(randomUserName + '@example.com');
28+
await page.getByLabel('Username').fill(randomUserName);
2929
});
3030

3131
await test.step('Test password confirm validation errors', async () => {
32-
await page.locator('#password').fill('test');
32+
await page.getByLabel('Password', { exact: true }).fill('test');
3333
await page.getByRole('button', { name: 'Save' }).click();
3434
expect(await page.getByText("Passwords don't match").count()).toEqual(1);
3535
});
@@ -38,9 +38,9 @@ test('Create, update and delete a user', async ({ page }) => {
3838
let userId = null;
3939

4040
await test.step('Create user', async () => {
41-
await page.locator('#confirmPassword').fill('test');
42-
await page.locator('#slurmUser').fill(randomUserName + '_slurm');
43-
await page.locator('#cacheDir').fill('/tmp/test');
41+
await page.getByLabel('Confirm password').fill('test');
42+
await page.getByLabel('SLURM user').fill(randomUserName + '_slurm');
43+
await page.getByLabel('Cache dir').fill('/tmp/test');
4444

4545
await page.getByRole('button', { name: 'Save' }).click();
4646
await page.waitForURL('/admin/users');
@@ -86,7 +86,7 @@ test('Create, update and delete a user', async ({ page }) => {
8686
});
8787

8888
await test.step('Test cache dir validation error', async () => {
89-
await page.locator('#cacheDir').fill('foo');
89+
await page.getByLabel('Cache dir').fill('foo');
9090
await page.getByRole('button', { name: 'Save' }).click();
9191
await page.waitForFunction(() => {
9292
const invalidFeeback = document
@@ -103,10 +103,10 @@ test('Create, update and delete a user', async ({ page }) => {
103103
});
104104

105105
await test.step('Rename username and set verified checkbox', async () => {
106-
await page.locator('#cacheDir').fill('/tmp/test');
107-
await page.locator('#username').fill(randomUserName + '-renamed');
108-
await page.locator('#slurmUser').fill(randomUserName + '_slurm-renamed');
109-
await page.locator('#verified').check();
106+
await page.getByLabel('Verified').check();
107+
await page.getByLabel('Cache dir').fill('/tmp/test');
108+
await page.getByLabel('Username').fill(randomUserName + '-renamed');
109+
await page.getByLabel('SLURM user').fill(randomUserName + '_slurm-renamed');
110110
await page.getByRole('button', { name: 'Save' }).click();
111111

112112
await page.waitForURL('/admin/users');

0 commit comments

Comments
 (0)