Added warning sign on tasks having new versions available

Author: zonia3000

src/lib/components/workflow/VersionUpdate.svelte

@@ -1,16 +1,16 @@
 <script>
-	import { greatestVersionAsc, greatestVersionDesc } from '$lib/common/component_utilities';
 	import { displayStandardErrorAlert } from '$lib/common/errors';
 	import { SchemaValidator } from '$lib/common/jschema_validation';
 	import { page } from '$app/stores';
 	import { stripSchemaProperties } from '../common/jschema/schema_management';
+	import { getNewVersions } from './version-checker';
 
 	/** @type {import('$lib/types').WorkflowTask} */
 	export let workflowTask;
 
 	/** @type {(workflowTask: import('$lib/types').WorkflowTask) => void} */
 	export let updateWorkflowCallback;
-	/** @type {(count: number) => void} */
+	/** @type {(count: number) => Promise<void>} */
 	export let updateNewVersionsCount;
 
 	$: task = workflowTask.task;
@@ -46,30 +46,14 @@
 			return;
 		}
 
-		console.log('Checking for new versions');
-		const response = await fetch('/api/v1/task');
-
-		if (!response.ok) {
-			errorAlert = displayStandardErrorAlert(await response.json(), 'versionUpdateError');
+		try {
+			updateCandidates = await getNewVersions(task);
+		} catch (error) {
+			errorAlert = displayStandardErrorAlert(error, 'versionUpdateError');
 			return;
 		}
 
-		/** @type {import('$lib/types').Task[]} */
-		const result = await response.json();
-
-		updateCandidates = result
-			.filter((t) => {
-				return (
-					t.name === task.name &&
-					t.owner === task.owner &&
-					t.version &&
-					t.args_schema &&
-					greatestVersionAsc(t, task) === 1
-				);
-			})
-			.sort(greatestVersionDesc);
-
-		updateNewVersionsCount(updateCandidates.length);
+		await updateNewVersionsCount(updateCandidates.length);
 	}
 
 	function checkArgumentsWithNewSchema() {

src/lib/components/workflow/version-checker.js

@@ -0,0 +1,44 @@
+import { greatestVersionAsc, greatestVersionDesc } from '$lib/common/component_utilities';
+import { AlertError } from '$lib/common/errors';
+
+/**
+ * @param {import('$lib/types').Task} task
+ * @returns {Promise<import('$lib/types').Task[]>} the list of update candidates for the given task
+ */
+export async function getNewVersions(task) {
+	const updateCandidates = await getAllNewVersions([task]);
+	return updateCandidates[task.id];
+}
+
+/**
+ * @param {import('$lib/types').Task[]} tasks
+ * @returns {Promise<{ [id: string]: import('$lib/types').Task[] }>} the list of update candidates, for each task received as input
+ */
+export async function getAllNewVersions(tasks) {
+	console.log('Checking for new versions');
+	const response = await fetch('/api/v1/task');
+
+	if (!response.ok) {
+		throw new AlertError(await response.json());
+	}
+
+	/** @type {import('$lib/types').Task[]} */
+	const result = await response.json();
+
+	return tasks.reduce(function (map, task) {
+		map[task.id] = result
+			.filter((t) => {
+				return (
+					task.args_schema !== null &&
+					task.version !== null &&
+					t.name === task.name &&
+					t.owner === task.owner &&
+					t.version &&
+					t.args_schema &&
+					greatestVersionAsc(t, task) === 1
+				);
+			})
+			.sort(greatestVersionDesc);
+		return map;
+	}, {});
+}

src/routes/projects/[projectId]/workflows/[workflowId]/+page.svelte

@@ -13,6 +13,7 @@
 	import Modal from '$lib/components/common/Modal.svelte';
 	import StandardDismissableAlert from '$lib/components/common/StandardDismissableAlert.svelte';
 	import VersionUpdate from '$lib/components/workflow/VersionUpdate.svelte';
+	import { getAllNewVersions } from '$lib/components/workflow/version-checker';
 
 	// Workflow
 	/** @type {import('$lib/types').Workflow|undefined} */
@@ -65,6 +66,9 @@
 	/** @type {Modal} */
 	let editWorkflowModal;
 
+	/** @type {{ [id: string]: import('$lib/types').Task[] }} */
+	let newVersionsMap = {};
+
 	$: updatableWorkflowList = workflow?.task_list || [];
 
 	workflowTaskContext.subscribe((value) => {
@@ -81,6 +85,7 @@
 		workflow = $page.data.workflow;
 		project = $page.data.project;
 		datasets = $page.data.datasets;
+		checkNewVersions();
 	});
 
 	beforeNavigate((navigation) => {
@@ -258,6 +263,7 @@
 			// UI Feedback
 			workflowSuccessMessage = 'Workflow task created';
 			resetCreateWorkflowTaskModal();
+			await checkNewVersions();
 		});
 	}
 
@@ -498,14 +504,21 @@
 		workflow = workflowResult;
 		selectedWorkflowTask = workflowTask;
 		workflowSuccessMessage = 'Task version updated successfully';
+		await checkNewVersions();
+	}
+
+	async function checkNewVersions() {
+		if (workflow) {
+			newVersionsMap = await getAllNewVersions(workflow.task_list.map((wt) => wt.task));
+		}
 	}
 
 	let newVersionsCount = 0;
 	/**
 	 * Used to receive new version count from VersionUpdate component.
 	 * @param count {number}
 	 */
-	function updateNewVersionsCount(count) {
+	async function updateNewVersionsCount(count) {
 		newVersionsCount = count;
 	}
 </script>
@@ -606,6 +619,12 @@
 									on:keypress|preventDefault
 								>
 									{workflowTask.task.name} #{workflowTask.id}
+
+									{#if newVersionsMap[workflowTask.task.id]?.length > 0}
+										<span class="float-end text-warning" title="new version available">
+											<i class="bi bi-exclamation-triangle" />
+										</span>
+									{/if}
 								</li>
 							{/each}
 						</ul>