Fixed wrong version count update

Author: zonia3000

__tests__/v2/VersionUpdate.test.js

@@ -24,6 +24,7 @@ function createFetchResponse(data) {
 
 // The component to be tested must be imported after the mock setup
 import VersionUpdate from '../../src/lib/components/v2/workflow/VersionUpdate.svelte';
+import { writable } from 'svelte/store';
 
 const newArgsSchema = {
 	title: 'MyTask',
@@ -700,7 +701,7 @@ function renderVersionUpdate(task, workflowTask, updateCandidates) {
 			workflowTask,
 			updateCandidates,
 			updateWorkflowCallback: nop,
-			updateNewVersionsCount: nop
+			newVersionsCount: writable(0)
 		}
 	});
 }

playwright.config.js

@@ -80,7 +80,7 @@ export default defineConfig({
 
 	webServer: [
 		{
-			command: './tests/start-test-server.sh --branch 2453-partly-move-task-version-update-from-fractal-web-to-fractal-server',
+			command: './tests/start-test-server.sh --branch main',
 			port: 8000,
 			waitForPort: true,
 			stdout: 'pipe',

src/lib/components/v2/workflow/VersionUpdate.svelte

@@ -14,11 +14,11 @@
 	 * @property {import('fractal-components/types/api').WorkflowTaskV2} workflowTask
 	 * @property {Array<{ task_id: number, version: string }>} updateCandidates
 	 * @property {(workflowTask: import('fractal-components/types/api').WorkflowTaskV2) => void} updateWorkflowCallback
-	 * @property {(count: number) => Promise<void>} updateNewVersionsCount
+	 * @property {import('svelte/store').Writable<number>} newVersionsCount
 	 */
 
 	/** @type {Props} */
-	let { workflowTask, updateCandidates, updateWorkflowCallback, updateNewVersionsCount } = $props();
+	let { workflowTask, updateCandidates, updateWorkflowCallback, newVersionsCount } = $props();
 
 	/** @type {VersionUpdateFixArgs|undefined} */
 	let fixArgsComponentNonParallel = $state();
@@ -40,20 +40,13 @@
 	/** @type {import('$lib/components/common/StandardErrorAlert.svelte').default|undefined} */
 	let errorAlert = undefined;
 
-	async function setup() {
+	function setup() {
 		if (errorAlert) {
 			errorAlert.hide();
 		}
 		selectedUpdateVersion = '';
 		fixArgsComponentNonParallel?.reset();
 		fixArgsComponentParallel?.reset();
-
-		await tick(); // wait taskHasArgsSchema is set
-		if (!taskHasArgsSchema) {
-			return;
-		}
-
-		await updateNewVersionsCount(updateCandidates.length);
 	}
 
 	/**
@@ -196,6 +189,10 @@
 	$effect(() => {
 		loadSelectedTask(selectedUpdateVersion);
 	});
+
+	$effect(() => {
+		newVersionsCount.set(updateCandidates.length);
+	});
 </script>
 
 <div>

src/routes/v2/projects/[projectId]/workflows/[workflowId]/+page.svelte

@@ -26,6 +26,7 @@
 	import RunStatus from '$lib/components/jobs/RunStatus.svelte';
 	import RunStatusModal from '$lib/components/jobs/RunStatusModal.svelte';
 	import { navigating, navigationCancelled } from '$lib/stores';
+	import { writable } from 'svelte/store';
 
 	/** @type {number|undefined} */
 	const defaultDatasetId = $derived(page.data.defaultDatasetId);
@@ -486,14 +487,7 @@
 		return updateCandidates;
 	}
 
-	let newVersionsCount = $state(0);
-	/**
-	 * Used to receive new version count from VersionUpdate component.
-	 * @param count {number}
-	 */
-	async function updateNewVersionsCount(count) {
-		newVersionsCount = count;
-	}
+	const newVersionsCount = writable(0);
 
 	/** @type {{[key: number]: import('fractal-components/types/api').ImagesStatus}} */
 	let statuses = $state({});
@@ -1013,8 +1007,8 @@
 											aria-current={workflowTabContextId === 4}
 										>
 											Version
-											{#if newVersionsCount}
-												<span class="badge bg-primary rounded-pill">{newVersionsCount}</span>
+											{#if $newVersionsCount}
+												<span class="badge bg-primary rounded-pill">{$newVersionsCount}</span>
 											{/if}
 										</button>
 									</li>
@@ -1103,7 +1097,7 @@
 										workflowTask={selectedWorkflowTask}
 										updateWorkflowCallback={taskUpdated}
 										updateCandidates={newVersionsMap[selectedWorkflowTask.task_id] || []}
-										{updateNewVersionsCount}
+										{newVersionsCount}
 									/>
 								{/if}
 							</div>