Merge pull request #492 from fractal-analytics-platform/log4js

Added backend logging using Log4js

Author: zonia3000

.env

@@ -6,11 +6,14 @@ AUTH_COOKIE_SECURE=false
 # remember to set this in production
 AUTH_COOKIE_DOMAIN=
 AUTH_COOKIE_PATH=/
-AUTH_COOKIE_MAX_AGE=1800
 AUTH_COOKIE_SAME_SITE=lax
-AUTH_COOKIE_HTTP_ONLY=true
 
 # PUBLIC VARIABLES (accessible from client side)
 PUBLIC_FRACTAL_ADMIN_SUPPORT_EMAIL=help@localhost
 PUBLIC_UPDATE_JOBS_INTERVAL=3000
 PUBLIC_OAUTH_CLIENT_NAME=
+
+# Logging
+LOG_FILE=/tmp/fractal-web.log
+LOG_LEVEL_FILE=info
+LOG_LEVEL_CONSOLE=warn

.env.development

@@ -5,11 +5,14 @@ AUTH_COOKIE_NAME=fastapiusersauth
 AUTH_COOKIE_SECURE=false
 AUTH_COOKIE_DOMAIN=
 AUTH_COOKIE_PATH=/
-AUTH_COOKIE_MAX_AGE=86400
 AUTH_COOKIE_SAME_SITE=lax
-AUTH_COOKIE_HTTP_ONLY=true
 
 # PUBLIC VARIABLES (accessible from client side)
 PUBLIC_FRACTAL_ADMIN_SUPPORT_EMAIL=help@localhost
 PUBLIC_UPDATE_JOBS_INTERVAL=3000
 PUBLIC_OAUTH_CLIENT_NAME=
+
+# Logging
+LOG_FILE=./fractal-web.log
+LOG_LEVEL_FILE=debug
+LOG_LEVEL_CONSOLE=info

.github/workflows/end_to_end_tests.yaml

@@ -35,7 +35,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: npm

.github/workflows/github_release.yaml

@@ -4,15 +4,45 @@ on:
     tags:
       - 'v[0-9]+.[0-9]+.[0-9]+'
       - 'v[0-9]+.[0-9]+.[0-9]+[a-c][0-9]+'
+      - 'v[0-9]+.[0-9]+.[0-9]+-[a-c][0-9]+'
       - 'v[0-9]+.[0-9]+.[0-9]+alpha[0-9]+'
       - 'v[0-9]+.[0-9]+.[0-9]+beta[0-9]+'
       - 'v[0-9]+.[0-9]+.[0-9]+rc[0-9]+'
 
 jobs:
   build:
     runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: ['16', '18', '20']
+
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+
+      - name: Set up node
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: npm
+
+      - name: Install dependencies
+        run: npm install
+
+      - name: Generate build artifacts
+        run: npm run build
+
+      - name: Generate the package
+        run: npm pack
+
+      - name: Extract the package
+        run: tar -xzf fractal-web-*.tgz
+
+      - name: Repack the package removing parent folder
+        run: tar -C package -czf node-${{ matrix.node-version }}-fractal-web-${{ github.ref_name }}.tar.gz build package.json node_modules LICENSE  
+
       - name: Release
-        uses: softprops/action-gh-release@v1
+        uses: softprops/action-gh-release@v2
+        with:
+          files: node-${{ matrix.node-version }}-fractal-web-${{ github.ref_name }}.tar.gz

.github/workflows/lint_and_build.yaml

@@ -21,7 +21,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: npm
@@ -39,9 +39,7 @@ jobs:
           AUTH_COOKIE_SECURE: false
           AUTH_COOKIE_DOMAIN:
           AUTH_COOKIE_PATH: /
-          AUTH_COOKIE_MAX_AGE: 1800
           AUTH_COOKIE_SAME_SITE: lax
-          AUTH_COOKIE_HTTP_ONLY: true
           PUBLIC_OAUTH_CLIENT_NAME:
           PUBLIC_FRACTAL_ADMIN_SUPPORT_EMAIL:
         run: npm run build

.github/workflows/unit_tests.yaml

@@ -21,7 +21,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: npm

.gitignore

@@ -14,3 +14,5 @@ coverage*/
 playwright-report/
 venv
 site
+*.log
+test-results/

CHANGELOG.md

@@ -2,6 +2,15 @@
 
 # Unreleased
 
+Note: with this release all the environment variables will be read from the environment, when the service is started, not during build time. Remember to load in your environment all the variables that you need when you start the service in production. This will not affect development setup.
+
+* Updated quickstart documenting the changes related to environment variables (\#492).
+* Fixed bug in default dataset selection when job references a deleted dataset (\#492).
+* Fixed v1 workflow task version update bug (\#492).
+* Added `npm pack` artifacts to files published by the CI during the release (\#492).
+* Fixed v2 admin job download link (\#492).
+* Imported all the environment variables dynamically (\#492).
+* Added backend logging using Log4js (\#492).
 * Improved JSON Schema Sandbox page (\#490).
 
 # 1.0.4

__tests__/v2/workflow_utilities.test.js

@@ -72,4 +72,15 @@ describe('Workflow Utilities', () => {
 		// return default dataset
 		expect(datasetId).toEqual(3);
 	});
+
+	it('Handles jobs with deleted datasets', () => {
+		const id = getDefaultWorkflowDataset(
+			[],
+			[
+				{ start_timestamp: '2024-04-24T15:18:37.868655+00:00', dataset_id: null },
+				{ start_timestamp: '2024-04-24T10:18:37.868655+00:00', dataset_id: 1 }
+			]
+		);
+		expect(id).toEqual(1);
+	});
 });