Handled edge case

Author: zonia3000

src/lib/components/v2/projects/datasets/DatasetImagesTable.svelte

@@ -385,7 +385,7 @@
 				body: JSON.stringify(params)
 			}
 		);
-		if (firstLoad) {
+		if (firstLoad && !runWorkflowModal) {
 			showTable = imagePage.total_count > 0;
 			firstLoad = false;
 		} else {

src/lib/components/v2/workflow/RunWorkflowModal.svelte

@@ -282,7 +282,7 @@
 				...task.type_filters
 			}
 		};
-		const response = await fetch(
+		let response = await fetch(
 			`/api/v2/project/${dataset.project_id}/dataset/${dataset.id}/images/query?page=1&page_size=10`,
 			{
 				method: 'POST',
@@ -299,6 +299,26 @@
 		imagePage = await response.json();
 		hasImages =
 			/** @type {import('fractal-components/types/api').ImagePage} */ (imagePage).total_count > 0;
+		if (!hasImages) {
+			// Verify if dataset without filters has images
+			let response = await fetch(
+				`/api/v2/project/${dataset.project_id}/dataset/${dataset.id}/images/query?page=1&page_size=10`,
+				{
+					method: 'POST',
+					headers,
+					credentials: 'include',
+					body: JSON.stringify({})
+				}
+			);
+			if (!response.ok) {
+				modal.displayErrorAlert(await getAlertErrorFromResponse(response));
+				datasetImagesLoading = false;
+				return;
+			}
+			/** @type {import('fractal-components/types/api').ImagePage} */
+			const result = await response.json();
+			hasImages = result.total_count > 0;
+		}
 		datasetImagesLoading = false;
 		await tick();
 		datasetImagesTable?.load();

tests/v2/images.spec.js

@@ -22,6 +22,7 @@ test('Dataset images [v2]', async ({ page, project }) => {
 		await page.getByRole('link', { name: 'test-dataset' }).click();
 		await page.waitForURL(/\/v2\/projects\/\d+\/datasets\/\d+/);
 		await expect(page.getByText('No entries in the image list yet')).toBeVisible();
+		await expect(page.getByRole('button', { name: 'Apply' })).not.toBeVisible();
 	});
 
 	await test.step('Create an image without filters', async () => {

tests/v2/run_workflow_image_list_visibility.spec.js

@@ -0,0 +1,72 @@
+import { selectSlimSelect, waitModalClosed, waitPageLoading } from '../utils.js';
+import { createImage } from './image_utils.js';
+import { expect, test } from './workflow_fixture.js';
+
+test('Image list visibility in run workflow modal', async ({ page, workflow }) => {
+	await page.waitForURL(workflow.url);
+	await waitPageLoading(page);
+
+	await page.goto(`/v2/projects/${workflow.projectId}`);
+	await waitPageLoading(page);
+
+	const modal = page.locator('.modal.show');
+	const randomPath = `/tmp/${Math.random().toString(36).substring(7)}`;
+
+	await test.step('Create test dataset', async () => {
+		const createDatasetButton = page.getByRole('button', { name: 'Create new dataset' });
+		await createDatasetButton.click();
+		await modal.waitFor();
+		await modal.getByRole('textbox', { name: 'Dataset Name' }).fill('test-dataset');
+		await modal.getByRole('textbox', { name: 'Zarr dir' }).fill(randomPath);
+		await modal.getByRole('button', { name: 'Save' }).click();
+		await waitModalClosed(page);
+	});
+
+	await test.step('Open workflow page and verify that image list is not displayed', async () => {
+		await page.goto(workflow.url);
+		await waitPageLoading(page);
+		await workflow.addTask('generic_task');
+		await page.getByRole('button', { name: 'Run workflow' }).click();
+		await modal.waitFor();
+		await expect(modal.getByText('Image list')).not.toBeVisible();
+	});
+
+	await test.step('Add images to the dataset', async () => {
+		await page.goto(`/v2/projects/${workflow.projectId}`);
+		await waitPageLoading(page);
+		await page.getByRole('link', { name: 'test-dataset' }).click();
+		await waitPageLoading(page);
+		await createImage(page, `${randomPath}/img1`, { a1: 'v1' });
+		await createImage(page, `${randomPath}/img2`, { a2: 'v2' });
+	});
+
+	await test.step('Add dataset filters that exclude all images', async () => {
+		await page.getByText('Current selection').click();
+		await expect(page.getByText(/Total results: 2/)).toBeVisible();
+		await selectSlimSelect(page, page.getByLabel('Selector for attribute a1'), 'v1');
+		await page.getByRole('button', { name: 'Apply' }).click();
+		await selectSlimSelect(page, page.getByLabel('Selector for attribute a2'), 'v2');
+		await page.getByRole('button', { name: 'Apply' }).click();
+		await expect(page.getByText(/Total results: 0/)).toBeVisible();
+		await page.getByRole('button', { name: 'Save' }).click();
+		await modal.getByRole('button', { name: 'Confirm' }).click();
+		await waitModalClosed(page);
+		await expect(page.getByRole('button', { name: 'Save' })).toBeDisabled();
+	});
+
+	await test.step('Open workflow page and verify that image list is displayed and table is empty', async () => {
+		await page.goto(workflow.url);
+		await waitPageLoading(page);
+		await page.getByRole('button', { name: 'Run workflow' }).click();
+		await modal.waitFor();
+		await expect(modal.getByRole('button', { name: 'Image list' })).toBeVisible();
+		await modal.getByRole('button', { name: 'Image list' }).click();
+		await expect(modal.getByText(/Total results: 0/)).toBeVisible();
+	});
+
+	await test.step('Deselect filter and check result', async () => {
+		await modal.locator('.ss-deselect').first().click();
+		await modal.getByRole('button', { name: 'Apply' }).click();
+		await expect(modal.getByText(/Total results: 1/)).toBeVisible();
+	});
+});