Removed unused fields and calls

Author: zonia3000

__tests__/v2/workflow_page.test.js

@@ -48,8 +48,6 @@ describe('Workflow page', () => {
 					switch (url) {
 						case '/api/v2/task':
 							return [{ id: 1, workflow_id: 1, task_id: 1, task: { id: 1, name: 'test' } }];
-						case '/api/v2/task-legacy':
-							return { data: [] };
 						case '/api/v2/project/1/dataset/1':
 							return { id: 1, name: 'test' };
 						case '/api/v2/project/1/status?dataset_id=1&workflow_id=1':

sandbox/src/lib/components/VersionUpdateSandbox.svelte

@@ -154,8 +154,7 @@
 		dummyWorkflowTask = {
 			id: 1,
 			args_parallel: deepCopy(oldSchemaData),
-			task_type: 'parallel',
-			is_legacy_task: false
+			task_type: 'parallel'
 		};
 
 		dummyUpdateCandidate = {

src/lib/components/v1/workflow/version-checker.js

@@ -3,21 +3,19 @@ import { AlertError } from '$lib/common/errors';
 
 /**
  * @param {import('$lib/types').Task} task
- * @param {boolean|false=} v2
  * @returns {Promise<import('$lib/types').Task[]>} the list of update candidates for the given task
  */
-export async function getNewVersions(task, v2) {
-	const updateCandidates = await getAllNewVersions([task], v2);
+export async function getNewVersions(task) {
+	const updateCandidates = await getAllNewVersions([task]);
 	return updateCandidates[task.id];
 }
 
 /**
  * @param {import('$lib/types').Task[]} tasks
- * @param {boolean|false=} v2
  * @returns {Promise<{ [id: string]: import('$lib/types').Task[] }>} the list of update candidates, for each task received as input
  */
-export async function getAllNewVersions(tasks, v2 = false) {
-	const response = await fetch(v2 ? `/api/v2/task-legacy` : `/api/v1/task`);
+export async function getAllNewVersions(tasks) {
+	const response = await fetch(`/api/v1/task`);
 
 	if (!response.ok) {
 		throw new AlertError(await response.json());

src/lib/components/v2/workflow/VersionUpdate.svelte

@@ -3,7 +3,7 @@
 	import { page } from '$app/stores';
 	import VersionUpdateFixArgs from './VersionUpdateFixArgs.svelte';
 	import { tick } from 'svelte';
-	import { getNewVersions as getNewVersionsV2 } from '$lib/components/v2/workflow/version-checker';
+	import { getNewVersions } from './version-checker';
 
 	/** @type {import('$lib/types-v2').WorkflowTaskV2} */
 	export let workflowTask;
@@ -78,7 +78,7 @@
 		}
 
 		try {
-			updateCandidates = await getNewVersionsV2(workflowTask.task);
+			updateCandidates = await getNewVersions(workflowTask.task);
 		} catch (error) {
 			errorAlert = displayStandardErrorAlert(error, 'versionUpdateError');
 			return;

src/lib/server/api/v2/task_api.js

@@ -29,26 +29,3 @@ export async function listTasks(fetch) {
 
 	return await response.json();
 }
-
-/**
- * Fetches a list of legacy tasks from the server
- * @param {typeof fetch} fetch
- * @returns {Promise<Array<import('$lib/types').Task>>}
- */
-export async function listLegacyTasks(fetch) {
-	logger.debug('Fetching legacy tasks');
-
-	// Compose request
-	const response = await fetch(env.FRACTAL_SERVER_HOST + '/api/v2/task-legacy/?args_schema=false', {
-		method: 'GET',
-		credentials: 'include',
-		mode: 'cors'
-	});
-
-	if (!response.ok) {
-		logger.error('Unable to fetch legacy tasks');
-		await responseError(response);
-	}
-
-	return await response.json();
-}

src/lib/types.d.ts

@@ -21,7 +21,6 @@ export type Task = {
   docs_link: string
   docs_info: string
   meta: object
-  is_v2_compatible: boolean
 }
 
 export type Workflow = {