Merge pull request #548 from fractal-analytics-platform/wft-error-before-exec

Displayed an error when job submission failed before starting execution of tasks

Author: zonia3000

CHANGELOG.md

@@ -1,5 +1,9 @@
 *Note: Numbers like (\#123) point to closed Pull Requests on the fractal-web repository.*
 
+# Unreleased
+
+* Displayed an error when job submission failed before starting execution of tasks (\#548);
+
 # 1.4.3
 
 * Added settings page to admin area (\#544);

__tests__/v2/workflow_page.test.js

@@ -0,0 +1,80 @@
+import { describe, it, beforeEach, expect, vi } from 'vitest';
+import { render } from '@testing-library/svelte';
+import { readable } from 'svelte/store';
+
+// Mocking fetch
+global.fetch = vi.fn();
+
+// Mocking the page store
+vi.mock('$app/stores', () => {
+	return {
+		page: readable({
+			data: {
+				workflow: {
+					id: 1,
+					name: 'test',
+					project_id: 1,
+					task_list: [{ id: 1, workflow_id: 1, task_id: 1, task: { id: 1, name: 'test' } }],
+					project: { id: 1, name: 'test' }
+				},
+				datasets: [{ id: 1, name: 'test' }],
+				defaultDatasetId: 1,
+				userInfo: { id: 1, slurm_accounts: [] }
+			},
+			params: { projectId: 1 }
+		})
+	};
+});
+
+// Mocking public variables
+vi.mock('$env/dynamic/public', () => {
+	return { env: {} };
+});
+
+// The component to be tested must be imported after the mock setup
+import page from '../../src/routes/v2/projects/[projectId]/workflows/[workflowId]/+page.svelte';
+
+describe('Workflow page', () => {
+	beforeEach(() => {
+		fetch.mockClear();
+	});
+
+	it('Display error when submission failed before starting execution of tasks', async () => {
+		fetch.mockImplementation((url) => {
+			return Promise.resolve({
+				ok: true,
+				status: 200,
+				json: async () => {
+					switch (url) {
+						case '/api/v2/task':
+							return [{ id: 1, workflow_id: 1, task_id: 1, task: { id: 1, name: 'test' } }];
+						case '/api/v2/task-legacy':
+							return { data: [] };
+						case '/api/v2/project/1/dataset/1':
+							return { id: 1, name: 'test' };
+						case '/api/v2/project/1/status?dataset_id=1&workflow_id=1':
+							return { status: {} }; // status is an empty object, since no tasks started
+						case '/api/v2/project/1/workflow/1/job':
+							return [
+								{
+									id: 1,
+									project_id: 1,
+									workflow_id: 1,
+									dataset_id: 1,
+									status: 'failed',
+									log: 'Exception error occurred while creating job folder and subfolders.\nOriginal error: test'
+								}
+							];
+						default:
+							throw Error(`Unexpected API call: ${url}`);
+					}
+				}
+			});
+		});
+
+		const result = render(page);
+		expect(
+			await result.findByText(/Exception error occurred while creating job folder and subfolders/)
+		).toBeDefined();
+	});
+});

package-lock.json

@@ -628,11 +628,13 @@
 	}
 
 	async function loadJobError() {
-		const failedStatus = Object.values(statuses).find((s) => s === 'failed');
-		if (!failedStatus) {
-			jobError = '';
-			failedJob = undefined;
-			return;
+		if (Object.values(statuses).length > 0) {
+			const failedStatus = Object.values(statuses).find((s) => s === 'failed');
+			if (!failedStatus) {
+				jobError = '';
+				failedJob = undefined;
+				return;
+			}
 		}
 		const response = await fetch(`/api/v2/project/${project.id}/workflow/${workflow.id}/job`, {
 			method: 'GET',
@@ -647,6 +649,8 @@
 			.filter((j) => j.dataset_id === selectedDatasetId && j.status === 'failed')
 			.sort((j1, j2) => (j1.start_timestamp < j2.start_timestamp ? 1 : -1));
 		if (failedJobs.length === 0) {
+			jobError = '';
+			failedJob = undefined;
 			return;
 		}
 		failedJob = failedJobs[0];