Skip to content

Commit d996932

Browse files
committed
Adapt to new variables
1 parent 294240e commit d996932

File tree

4 files changed

+19
-15
lines changed

4 files changed

+19
-15
lines changed

.github/workflows/end_to_end_tests.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,11 @@ jobs:
1313
timeout-minutes: 20
1414

1515
env:
16-
OAUTH_DEXIDP_CLIENT_ID: client_test_web_id
17-
OAUTH_DEXIDP_CLIENT_SECRET: client_test_web_secret
18-
OAUTH_DEXIDP_REDIRECT_URL: "http://localhost:5173/auth/login/oauth2/"
19-
OAUTH_DEXIDP_OIDC_CONFIGURATION_ENDPOINT: "http://127.0.0.1:5556/dex/.well-known/openid-configuration"
16+
OAUTH_CLIENT_name: dexidp
17+
OAUTH_CLIENT_ID: client_test_web_id
18+
OAUTH_CLIENT_SECRET: client_test_web_secret
19+
OAUTH_REDIRECT_URL: "http://localhost:5173/auth/login/oauth2/"
20+
OAUTH_OIDC_CONFIG_ENDPOINT: "http://127.0.0.1:5556/dex/.well-known/openid-configuration"
2021
PUBLIC_OAUTH_CLIENT_NAME: dexidp
2122
PUBLIC_FRACTAL_DATA_URL: http://localhost:3000/data
2223
PUBLIC_FRACTAL_VIZARR_VIEWER_URL: http://localhost:3000/data/vizarr

docs/development/tests.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,11 @@ To skip Pixi test set the environment variable `SKIP_PIXI_TEST` to `true`.
2525
To run the OAuth2 test locally add the following configuration to `.fractal_server.env`:
2626

2727
```
28-
OAUTH_DEXIDP_CLIENT_ID=client_test_web_id
29-
OAUTH_DEXIDP_CLIENT_SECRET=client_test_web_secret
30-
OAUTH_DEXIDP_REDIRECT_URL=http://localhost:5173/auth/login/oauth2/
31-
OAUTH_DEXIDP_OIDC_CONFIGURATION_ENDPOINT=http://127.0.0.1:5556/dex/.well-known/openid-configuration
28+
OAUTH_CLIENT_name=dexidp
29+
OAUTH_CLIENT_ID=client_test_web_id
30+
OAUTH_CLIENT_SECRET=client_test_web_secret
31+
OAUTH_REDIRECT_URL=http://localhost:5173/auth/login/oauth2/
32+
OAUTH_OIDC_CONFIG_ENDPOINT=http://127.0.0.1:5556/dex/.well-known/openid-configuration
3233
```
3334

3435
And then start the test IdP container:

docs/oauth2.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,10 @@ This variable has to match the client name defined in fractal-server configurati
2222
* Authorization callback URL: http://127.0.0.1:5173/auth/login/oauth2/
2323
2. Set up the following env variables for fractal-server:
2424
```
25-
OAUTH_GITHUB_CLIENT_ID=...
26-
OAUTH_GITHUB_CLIENT_SECRET=...
27-
OAUTH_GITHUB_REDIRECT_URL=http://127.0.0.1:5173/auth/login/oauth2/
25+
OAUTH_CLIENT_name=github
26+
OAUTH_CLIENT_ID=...
27+
OAUTH_CLIENT_SECRET=...
28+
OAUTH_REDIRECT_URL=http://127.0.0.1:5173/auth/login/oauth2/
2829
# [all other variables]
2930
```
3031
3. Set up the following env variables for fractal-web:

tests/start-test-server.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,11 @@ if [ ! -d "$fractal_server_test_path" ]; then
3434
cp "$(pwd)/tests/resource.json" "$fractal_server_test_path"
3535

3636
if [ "$SKIP_OAUTH_TEST" != "true" ]; then
37-
echo "\nOAUTH_DEXIDP_CLIENT_ID=client_test_web_id" >> "${fractal_server_test_path}/.fractal_server.env"
38-
echo "OAUTH_DEXIDP_CLIENT_SECRET=client_test_web_secret" >> "${fractal_server_test_path}/.fractal_server.env"
39-
echo "OAUTH_DEXIDP_REDIRECT_URL=http://localhost:5173/auth/login/oauth2/" >> "${fractal_server_test_path}/.fractal_server.env"
40-
echo "OAUTH_DEXIDP_OIDC_CONFIGURATION_ENDPOINT=http://127.0.0.1:5556/dex/.well-known/openid-configuration" >> "${fractal_server_test_path}/.fractal_server.env"
37+
echo "\nOAUTH_CLIENT_NAME=dexidp" >> "${fractal_server_test_path}/.fractal_server.env"
38+
echo "OAUTH_CLIENT_ID=client_test_web_id" >> "${fractal_server_test_path}/.fractal_server.env"
39+
echo "OAUTH_CLIENT_SECRET=client_test_web_secret" >> "${fractal_server_test_path}/.fractal_server.env"
40+
echo "OAUTH_REDIRECT_URL=http://localhost:5173/auth/login/oauth2/" >> "${fractal_server_test_path}/.fractal_server.env"
41+
echo "OAUTH_OIDC_CONFIG_ENDPOINT=http://127.0.0.1:5556/dex/.well-known/openid-configuration" >> "${fractal_server_test_path}/.fractal_server.env"
4142
fi
4243

4344
cd "$fractal_server_test_path"

0 commit comments

Comments
 (0)