Skip to content

Commit f3d75d9

Browse files
committed
Merge branch 'improve-jschema-layout'
2 parents 500bbdf + 991e5fd commit f3d75d9

File tree

7 files changed

+24
-14
lines changed

7 files changed

+24
-14
lines changed

src/lib/components/common/jschema/ArrayProperty.svelte

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929
3030
{#if schemaProperty }
3131
<div class='d-flex flex-column p-2'>
32-
<div class='property-metadata d-flex flex-column w-50'>
33-
<span class='fs-4 {schemaProperty.isRequired() ? "fw-bold" : ""}'>{ schemaProperty.title }</span>
34-
<span>{schemaProperty.description }</span>
32+
<div class='property-metadata d-flex flex-column w-100'>
33+
<span class='fs-5 {schemaProperty.isRequired() ? "fw-bold" : ""}'>{ schemaProperty.title }</span>
34+
<span class='small'>{schemaProperty.description }</span>
3535
</div>
3636
<div class='array-items my-2'>
3737
@@ -40,7 +40,7 @@
4040
<div class='accordion-item'>
4141
<div class='accordion-header'>
4242
<button class='accordion-button' type='button' data-bs-toggle='collapse'
43-
data-bs-target='#{collapseSymbol}'>List arguments
43+
data-bs-target='#{collapseSymbol}'>Arguments list
4444
</button>
4545
</div>
4646
<div id='{collapseSymbol}' class='accordion-collapse collapse show' data-bs-parent='#{accordionParentKey}'>

src/lib/components/common/jschema/BooleanProperty.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
{#if schemaProperty}
1515
<div class='d-flex align-items-center p-2'>
1616
<div class='property-metadata d-flex flex-column align-self-center w-50'>
17-
<span class='fs-4'>{ schemaProperty.title || 'Boolean argument' }</span>
17+
<span class='fs-5'>{ schemaProperty.title || 'Boolean argument' }</span>
1818
{#if schemaProperty.description }
19-
<span>{ schemaProperty.description }</span>
19+
<span class='small'>{ schemaProperty.description }</span>
2020
{/if}
2121
</div>
2222
<div class='property-input ms-auto w-25'>

src/lib/components/common/jschema/NumberProperty.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
<div class='d-flex align-items-center p-2'>
1919
<div class='property-metadata d-flex flex-column align-self-center w-50'>
2020
<span
21-
class='fs-4 {schemaProperty.isRequired() ? "fw-bold" : ""}'>{ schemaProperty.title || 'Number argument' }</span>
21+
class='fs-5 {schemaProperty.isRequired() ? "fw-bold" : ""}'>{ schemaProperty.title || 'Number argument' }</span>
2222
{#if schemaProperty.description }
23-
<span>{ schemaProperty.description }</span>
23+
<span class='small'>{ schemaProperty.description }</span>
2424
{/if}
2525
</div>
2626
<div class='property-input ms-auto w-25'>

src/lib/components/common/jschema/ObjectProperty.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@
3636
{#if objectSchema}
3737

3838
<div class='d-flex flex-column p-2'>
39-
<div class='property-metadata d-flex flex-column w-50'>
40-
<span class='fs-4 {objectSchema.isRequired() ? "fw-bold" : ""}'>{ objectSchema.title }</span>
41-
<span>{ objectSchema.description }</span>
39+
<div class='property-metadata d-flex flex-column w-100'>
40+
<span class='fs-5 {objectSchema.isRequired() ? "fw-bold" : ""}'>{ objectSchema.title }</span>
41+
<span class='small'>{ objectSchema.description }</span>
4242
</div>
4343
<div class='object-properties my-2'>
4444
<div class='accordion' id='{accordionParentKey}'>

src/lib/components/common/jschema/StringProperty.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
<div class='d-flex align-items-center p-2'>
1616
<div class='property-metadata d-flex flex-column align-self-center w-50'>
1717
<span
18-
class='fs-4 {schemaProperty.isRequired() ? "fw-bold" : ""}'>{ schemaProperty.title || 'String argument' }</span>
18+
class='fs-5 {schemaProperty.isRequired() ? "fw-bold" : ""}'>{ schemaProperty.title || 'String argument' }</span>
1919
{#if schemaProperty.description}
20-
<span>{ schemaProperty.description }</span>
20+
<span class='small'>{ schemaProperty.description }</span>
2121
{/if}
2222
</div>
2323
<div class='property-input ms-auto w-25'>

src/lib/components/workflow/ArgumentsSchema.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
Save changes
8989
</button>
9090
</div>
91-
<div>
91+
<div class='ms-1'>
9292
<button class='btn btn-warning {unsavedChanges ? "" : "disabled"}' on:click={resetChanges.bind(this, args)}>
9393
Discard changes
9494
</button>

src/routes/projects/[projectId]/workflows/[workflowId]/+page.svelte

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
let workerInitControl = '';
3030
let argsSchemaAvailable = undefined;
3131
let argsSchemaValid = undefined;
32+
let argsChangesSaved = false;
3233
3334
$: updatableWorkflowList = workflow?.task_list || [];
3435
@@ -264,6 +265,10 @@
264265
function handleArgsSaved(event) {
265266
selectedWorkflowTask.args = event.detail.args;
266267
selectedWorkflowTask = selectedWorkflowTask;
268+
argsChangesSaved = true;
269+
setTimeout(() => {
270+
argsChangesSaved = false;
271+
}, 3000);
267272
}
268273
269274
</script>
@@ -408,6 +413,11 @@
408413
{#if selectedWorkflowTask}
409414
{#key selectedWorkflowTask}
410415
{#if argsSchemaAvailable && argsSchemaValid}
416+
{#if argsChangesSaved }
417+
<div class='alert alert-success m-3' role='alert'>
418+
Arguments changes saved successfully
419+
</div>
420+
{/if}
411421
<ArgumentsSchema
412422
workflowId={workflow.id}
413423
workflowTaskId={selectedWorkflowTask.id}

0 commit comments

Comments
 (0)