Use mattr_accessor for most things, since they can't be string from ENV variables anyway

Author: fractaledmind

lib/solid_errors.rb

@@ -10,41 +10,27 @@ module SolidErrors
   mattr_accessor :base_controller_class, default: "::ActionController::Base"
   mattr_writer :username
   mattr_writer :password
-  mattr_writer :send_emails
-  mattr_writer :email_from
-  mattr_writer :email_to
-  mattr_writer :email_subject_prefix
-  mattr_writer :destroy_after
+  mattr_accessor :send_emails, default: false
+  mattr_accessor :email_from, default: "[email protected]"
+  mattr_accessor :email_to
+  mattr_accessor :email_subject_prefix
+  mattr_accessor :destroy_after
 
   class << self
     # use method instead of attr_accessor to ensure
-    # this works if variable set after SolidErrors is loaded
+    # this works if ENV variable set after SolidErrors is loaded
     def username
       @username ||= ENV["SOLIDERRORS_USERNAME"] || @@username
     end
 
+    # use method instead of attr_accessor to ensure
+    # this works if ENV variable set after SolidErrors is loaded
     def password
       @password ||= ENV["SOLIDERRORS_PASSWORD"] || @@password
     end
 
     def send_emails?
-      @send_emails ||= ENV["SOLIDERRORS_SEND_EMAILS"] || @@send_emails || false
-    end
-
-    def email_from
-      @email_from ||= ENV["SOLIDERRORS_EMAIL_FROM"] || @@email_from || "[email protected]"
-    end
-
-    def email_to
-      @email_to ||= ENV["SOLIDERRORS_EMAIL_TO"] || @@email_to
-    end
-
-    def email_subject_prefix
-      @email_subject_prefix ||= ENV["SOLIDERRORS_EMAIL_SUBJECT_PREFIX"] || @@email_subject_prefix
-    end
-
-    def destroy_after
-      @destroy_after ||= ENV["SOLIDERRORS_DESTROY_AFTER"] || @@destroy_after
+      send_emails && email_to.present?
     end
   end
 end