feat(field): add range check to PrimeFieldAttr

Author: batzor

tests/Dialect/Field/prime_field_to_mod_arith.mlir

@@ -1,7 +1,6 @@
 // RUN: zkir-opt -prime-field-to-mod-arith --split-input-file %s | FileCheck %s --enable-var-scope
 !PF1 = !field.pf<3:i32>
 !PFv = tensor<4x!PF1>
-#elem = #field.pf_elem<31:i32> : !PF1
 #root_elem = #field.pf_elem<2:i32> : !PF1
 #root = #field.root_of_unity<#root_elem, 2>
 

zkir/Dialect/Field/IR/FieldAttributes.cpp

@@ -8,13 +8,25 @@ namespace mlir::zkir::field {
 
 LogicalResult PrimeFieldAttr::verify(
     ::llvm::function_ref<::mlir::InFlightDiagnostic()> emitError,
-    PrimeFieldType type, IntegerAttr value) {
-  if (type.getModulus().getValue().getBitWidth() !=
-      value.getValue().getBitWidth()) {
+    PrimeFieldType type, IntegerAttr _value) {
+  APInt modulus = type.getModulus().getValue();
+  APInt value = _value.getValue();
+
+  // check if storage type is same
+  if (modulus.getBitWidth() != value.getBitWidth()) {
     emitError()
         << "prime field modulus bitwidth does not match the value bitwidth";
     return failure();
   }
+
+  // check if value is in the field defined by modulus
+  if (value.uge(modulus)) {
+    emitError() << value.getZExtValue()
+                << " is not in the field defined by modulus "
+                << modulus.getZExtValue();
+    return failure();
+  }
+
   return success();
 }