Skip to content

Commit a32ce61

Browse files
Use strict mode and use a safer for loop
We want to check to make sure that the property we're looking at is actually from the object, not from its prototype.
1 parent 6a9e0b9 commit a32ce61

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

index.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,19 @@
1-
request = require('request');
1+
'use strict';
2+
3+
var request = require('request');
24

35
var objectToParams = function(obj) {
46
var first = true;
57
var params = '?';
68
for (var key in obj) {
7-
if (first) {
8-
first = false;
9-
} else {
10-
params += '&';
9+
if (obj.hasOwnProperty(key)) {
10+
if (first) {
11+
first = false;
12+
} else {
13+
params += '&';
14+
}
15+
params += key + '=' + obj[key];
1116
}
12-
params += key + '=' + obj[key];
1317
}
1418
};
1519

0 commit comments

Comments
 (0)