Merge pull request #497 from framer/use-number-isfinite

madebyisaacr · web-flow · commit 17891eb09e50 · 2025-11-26T18:13:22.000Z
Resolve feedback from #495
diff --git a/plugins/notion/src/api.ts b/plugins/notion/src/api.ts
@@ -269,7 +269,7 @@ export function getSlugValue(property: PageObjectResponse["properties"][string])
                 }
                 case "number": {
                     const number = property.formula.number
-                    return typeof number === "number" && !isNaN(number) ? String(number) : null
+                    return Number.isFinite(number) ? String(number) : null
                 }
                 case "boolean": {
                     const boolean = property.formula.boolean

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ export function getSlugValue(property: PageObjectResponse["properties"][string])`
`269`	`269`	`}`
`270`	`270`	`case "number": {`
`271`	`271`	`const number = property.formula.number`
`272`		`- return typeof number === "number" && !isNaN(number) ? String(number) : null`
	`272`	`+ return Number.isFinite(number) ? String(number) : null`
`273`	`273`	`}`
`274`	`274`	`case "boolean": {`
`275`	`275`	`const boolean = property.formula.boolean`