Skip to content

Commit 6cdf735

Browse files
committed
From feedback
1 parent d7be25d commit 6cdf735

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

packages/code-link-cli/src/controller.rename.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@ describe("rename confirmation bookkeeping", () => {
2525
})
2626

2727
it("skips echoed remote renames when write and delete collapse into one watcher rename", async () => {
28+
const content = "export const New = () => null"
2829
const hashTracker = createHashTracker()
29-
hashTracker.remember("New.tsx", "export const New = () => null")
30+
hashTracker.remember("New.tsx", content)
3031
hashTracker.markDelete("Old.tsx")
3132

3233
const pendingRenameConfirmations = new Map<string, { oldFileName: string; content: string }>()
@@ -36,7 +37,7 @@ describe("rename confirmation bookkeeping", () => {
3637
type: "SEND_FILE_RENAME",
3738
oldFileName: "Old.tsx",
3839
newFileName: "New.tsx",
39-
content: "export const New = () => null",
40+
content,
4041
},
4142
{
4243
config: {
@@ -64,6 +65,7 @@ describe("rename confirmation bookkeeping", () => {
6465

6566
expect(sendMessage).not.toHaveBeenCalled()
6667
expect(hashTracker.shouldSkipDelete("Old.tsx")).toBe(false)
68+
expect(hashTracker.shouldSkip("New.tsx", content)).toBe(false)
6769
expect(pendingRenameConfirmations.size).toBe(0)
6870
})
6971

packages/code-link-cli/src/controller.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -957,6 +957,7 @@ async function executeEffect(
957957
hashTracker.shouldSkipDelete(effect.oldFileName)
958958

959959
if (isEchoedRename) {
960+
hashTracker.forget(normalizedNewFileName)
960961
hashTracker.clearDelete(effect.oldFileName)
961962
debug(`Skipping echoed rename ${effect.oldFileName} -> ${effect.newFileName}`)
962963
return []

0 commit comments

Comments
 (0)