Skip to content

Commit 11c27e0

Browse files
committed
fix(link): don't render href attribute in ListItem if href is false
fixes #4288
1 parent de92ec2 commit 11c27e0

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

src/react/components/list-item.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ const ListItem = forwardRef((props, ref) => {
352352
// Link
353353
if (link || href || accordionItem || smartSelect) {
354354
const linkAttrs = {
355-
href: link === true ? '' : link || href,
355+
href: href === false ? undefined : link === true ? href || '' : link || href,
356356
target,
357357
'data-tab': (isStringProp(tabLink) && tabLink) || undefined,
358358
...routerAttrs(props),

src/svelte/components/list-item.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@
143143
);
144144
145145
$: linkAttrs = {
146-
href: link === true ? '' : link || href,
146+
href: href === false ? undefined : link === true ? href || '' : link || href,
147147
target,
148148
'data-tab': (isStringProp(tabLink) && tabLink) || undefined,
149149
...routerAttrs($$props),

src/vue/components/list-item.vue

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,12 @@ export default {
452452
);
453453
454454
const linkAttrs = computed(() => ({
455-
href: props.link === true ? '' : props.link || props.href,
455+
href:
456+
props.href === false
457+
? undefined
458+
: props.link === true
459+
? props.href || ''
460+
: props.link || props.href,
456461
target: props.target,
457462
'data-tab': (isStringProp(props.tabLink) && props.tabLink) || undefined,
458463
...routerAttrs(props),

0 commit comments

Comments
 (0)