FIX ConditionList->not() missing in RelationalExpression

Author: francerz

src/Driver/QueryCompiler.php

@@ -348,7 +348,8 @@ protected function compileComparison(ComparisonOperationInterface $expr): string
 
     protected function compileRelationalExpression(RelationalExpression $expr): string
     {
-        $output = $this->compileComparable($expr->getOperand1());
+        $output = $expr->isNegated() ? 'NOT ' : '';
+        $output .= $this->compileComparable($expr->getOperand1());
         $output .= $this->compileRelationalOperator($expr->getOperator());
         $output .= $this->compileComparable($expr->getOperand2());
         return $output;

src/Expressions/Comparison/RelationalExpression.php

@@ -3,6 +3,7 @@
 namespace Francerz\SqlBuilder\Expressions\Comparison;
 
 use Francerz\SqlBuilder\Expressions\ComparableComponentInterface;
+use Francerz\SqlBuilder\Expressions\NegatableInterface;
 use Francerz\SqlBuilder\Expressions\TwoOperandsInterface;
 use Francerz\SqlBuilder\Nesting\NestOperationResolverInterface;
 use Francerz\SqlBuilder\Nesting\NestTranslator;
@@ -14,13 +15,16 @@
 class RelationalExpression implements
     ComparisonOperationInterface,
     TwoOperandsInterface,
+    NegatableInterface,
     NestOperationResolverInterface
 {
 
     private $operand1;
     private $operand2;
     private $operator;
 
+    private $negated = false;
+
     public function __construct(
         ComparableComponentInterface $operand1,
         ComparableComponentInterface $operand2,
@@ -66,6 +70,16 @@ public function getOperator()
         return $this->operator;
     }
 
+    public function negate(bool $negate = true)
+    {
+        $this->negated = $negate;
+    }
+
+    public function isNegated(): bool
+    {
+        return $this->negated;
+    }
+
     public function requiresTransform(): bool
     {
         return $this->operand1 instanceof ValueProxy || $this->operand2 instanceof ValueProxy;

test/SelectQueryTest.php

@@ -157,4 +157,15 @@ public function testWhereArgs()
 
         $this->assertEquals($expected, $compiled->getQuery());
     }
+
+    public function testWhereNot()
+    {
+        $query = Query::selectFrom(['groups']);
+        $query->where()->not('group_id', 1);
+
+        $compiled = $this->compiler->compileSelect($query);
+
+        $expected = "SELECT groups.* FROM groups WHERE NOT group_id = :v1";
+        $this->assertEquals($expected, $compiled->getQuery());
+    }
 }