Skip to content

Commit 91c7d2b

Browse files
committed
fixed buildextension and added some tests
1 parent 4344017 commit 91c7d2b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/core.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,8 @@ php_band_pecl_build_extension() {
187187
local ext_channel="$1"
188188
local user_input="${2}"
189189
log_info "Building pecl extension ${ext_channel}"
190-
echo "${user_input}" | ${php_band_php_install_dir}/bin/pecl install "${ext_channel}" # > /dev/null
191-
[ -z $? ] || log_info "Extension building failed"
190+
echo "${user_input}" | ${php_band_php_install_dir}/bin/pecl install "${ext_channel}" > /dev/null
191+
[ $? -eq 0 ] || log_info "Extension building failed"
192192
}
193193

194194
php_band_pecl_build() {
@@ -197,7 +197,7 @@ php_band_pecl_build() {
197197
for pecl_channel in ${!PHP_BAND_CUSTOM_PECL_EXTENSIONS[*]} ; do
198198
echo "Pecl extension $pecl_channel requested"
199199
cd "$cwd"
200-
custom_build_pecl_extension "$pecl_channel" "${PHP_BAND_CUSTOM_PECL_EXTENSIONS[${pecl_channel}]}"
200+
php_band_pecl_build_extension "$pecl_channel" "${PHP_BAND_CUSTOM_PECL_EXTENSIONS[${pecl_channel}]}"
201201
done
202202
cd "$cwd"
203203
}

test/10_simple_commands.bats

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load test_helper
44

55
@test "Call php-band with query version argument" {
66
run bin/php-band --version
7-
assert_output "0.2.0"
7+
assert_output "0.3.0"
88
assert_success
99
}
1010

0 commit comments

Comments
 (0)