fix(#247): address code review feedback from CodeRabbit

Fixes:
- Fix critical bug: use self.answer_capture (not self._answer_capture) in full_reset_discovery
- Add clear() method to AnswerCapture class for proper state reset
- Add thread safety lock (_sync_lock) in delete_project_tasks_and_issues
- Update Dialog onOpenChange handler to call handleCancelRestart when closed
- Update phase_manager.py docstring to document discovery restart transitions
- Remove unused api_client fixture from TestPhaseManagerTransitions tests

Author: Test User

codeframe/agents/lead_agent.py

@@ -751,9 +751,9 @@ def full_reset_discovery(self) -> dict:
         self._category_coverage = {}
         self._coverage_turn_count = 0
 
-        # Clear DiscoveryAnswerCapture state if it exists
-        if hasattr(self, "_answer_capture") and self._answer_capture:
-            self._answer_capture.clear()
+        # Clear AnswerCapture state if it exists
+        if hasattr(self, "answer_capture") and self.answer_capture:
+            self.answer_capture.clear()
 
         # Reset state in database
         self.db.upsert_memory(

codeframe/core/phase_manager.py

@@ -44,8 +44,8 @@ class PhaseManager:
     Phase Transition Rules:
         discovery → planning (forward only)
         planning → active, discovery (forward or back)
-        active → review, planning (forward or back)
-        review → complete, active (forward or back)
+        active → review, planning, discovery (forward or back to discovery for restart)
+        review → complete, active, discovery (forward or back to discovery for restart)
         complete → (terminal state)
 
     Example:

codeframe/discovery/answers.py

@@ -22,6 +22,14 @@ def __init__(self) -> None:
         """Initialize the AnswerCapture instance."""
         self.answers: dict[str, dict[str, Any]] = {}
 
+    def clear(self) -> None:
+        """Clear all captured answers.
+
+        Resets the internal state to an empty dictionary, effectively
+        clearing all previously captured answers.
+        """
+        self.answers = {}
+
     def capture_answer(self, question_id: str, answer_text: str) -> bool:
         """Capture an answer for a specific question.
 

codeframe/persistence/database.py

@@ -730,36 +730,37 @@ def delete_project_tasks_and_issues(self, project_id: int) -> dict:
         Returns:
             Dictionary with counts: {"tasks": int, "issues": int}
         """
-        cursor = self.conn.cursor()
-
-        # Count tasks before deletion
-        cursor.execute(
-            "SELECT COUNT(*) FROM tasks WHERE project_id = ?",
-            (project_id,),
-        )
-        task_count = cursor.fetchone()[0]
-
-        # Count issues before deletion
-        cursor.execute(
-            "SELECT COUNT(*) FROM issues WHERE project_id = ?",
-            (project_id,),
-        )
-        issue_count = cursor.fetchone()[0]
-
-        # Delete tasks first (due to FK constraint on issue_id)
-        cursor.execute(
-            "DELETE FROM tasks WHERE project_id = ?",
-            (project_id,),
-        )
-
-        # Then delete issues
-        cursor.execute(
-            "DELETE FROM issues WHERE project_id = ?",
-            (project_id,),
-        )
-
-        self.conn.commit()
-        return {"tasks": task_count, "issues": issue_count}
+        with self._sync_lock:
+            cursor = self.conn.cursor()
+
+            # Count tasks before deletion
+            cursor.execute(
+                "SELECT COUNT(*) FROM tasks WHERE project_id = ?",
+                (project_id,),
+            )
+            task_count = cursor.fetchone()[0]
+
+            # Count issues before deletion
+            cursor.execute(
+                "SELECT COUNT(*) FROM issues WHERE project_id = ?",
+                (project_id,),
+            )
+            issue_count = cursor.fetchone()[0]
+
+            # Delete tasks first (due to FK constraint on issue_id)
+            cursor.execute(
+                "DELETE FROM tasks WHERE project_id = ?",
+                (project_id,),
+            )
+
+            # Then delete issues
+            cursor.execute(
+                "DELETE FROM issues WHERE project_id = ?",
+                (project_id,),
+            )
+
+            self.conn.commit()
+            return {"tasks": task_count, "issues": issue_count}
 
     def create_audit_log(self, *args, **kwargs):
         """Delegate to audit_logs.create_audit_log()."""

tests/api/test_discovery_restart.py

@@ -471,19 +471,19 @@ def test_full_reset_resets_answer_capture_state(self, mock_provider_class, api_c
 class TestPhaseManagerTransitions:
     """Test phase manager allows transitions back to discovery from any phase."""
 
-    def test_active_to_discovery_transition_allowed(self, api_client):
+    def test_active_to_discovery_transition_allowed(self):
         """Test transition from active to discovery is allowed."""
         from codeframe.core.phase_manager import PhaseManager
 
         assert PhaseManager.can_transition("active", "discovery") is True
 
-    def test_review_to_discovery_transition_allowed(self, api_client):
+    def test_review_to_discovery_transition_allowed(self):
         """Test transition from review to discovery is allowed."""
         from codeframe.core.phase_manager import PhaseManager
 
         assert PhaseManager.can_transition("review", "discovery") is True
 
-    def test_planning_to_discovery_transition_already_allowed(self, api_client):
+    def test_planning_to_discovery_transition_already_allowed(self):
         """Test transition from planning to discovery is already allowed."""
         from codeframe.core.phase_manager import PhaseManager
 

web-ui/src/components/DiscoveryProgress.tsx

@@ -1104,7 +1104,7 @@ const DiscoveryProgress = memo(function DiscoveryProgress({ projectId, onViewPRD
       )}
 
       {/* Restart Discovery Confirmation Dialog (Issue #247) */}
-      <Dialog open={showRestartConfirmation} onOpenChange={setShowRestartConfirmation}>
+      <Dialog open={showRestartConfirmation} onOpenChange={(open) => { if (!open) handleCancelRestart(); }}>
         <DialogContent className="sm:max-w-[425px]">
           <DialogHeader>
             <div className="flex items-center gap-2">