Skip to content

Commit b0a1006

Browse files
authored
build: update @biomejs/biome to 2.x (microsoft#26617)
## Summary - Update `@biomejs/biome` from `~1.9.x` to `~2.4.5` across all packages in both the client and build-tools release groups - Remove temporary `@biomejs/biome` pnpm overrides from both root and build-tools `package.json` that were used to stage the upgrade - Remove syncpack workarounds: the biome ignore rule in `build-tools/syncpack.config.cjs` and the biome entry from version compatibility workarounds in `syncpack.config.cjs` - Apply biome 2.x formatting changes: removal of unused generic type parameters in `exposedInternalUtilityTypes.ts`, `typeUtils.ts`, and `latestValueTypes.ts` - Collateral lockfile changes: `acorn` 8.15.0 -> 8.16.0 and `acorn-walk` 8.3.4 -> 8.3.5 resolved as part of the lockfile update
1 parent 8152658 commit b0a1006

File tree

178 files changed

+1160
-1138
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

178 files changed

+1160
-1138
lines changed

azure/packages/azure-local-service/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"tinylicious": "^7.0.0"
3232
},
3333
"devDependencies": {
34-
"@biomejs/biome": "~1.9.3",
34+
"@biomejs/biome": "~2.4.5",
3535
"@fluidframework/build-common": "^2.0.3",
3636
"@fluidframework/build-tools": "^0.63.0",
3737
"@fluidframework/eslint-config-fluid": "workspace:~",

azure/packages/azure-service-utils/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@
9393
},
9494
"devDependencies": {
9595
"@arethetypeswrong/cli": "^0.18.2",
96-
"@biomejs/biome": "~1.9.3",
96+
"@biomejs/biome": "~2.4.5",
9797
"@fluid-tools/build-cli": "^0.63.0",
9898
"@fluidframework/azure-service-utils-previous": "npm:@fluidframework/azure-service-utils@2.83.0",
9999
"@fluidframework/build-common": "^2.0.3",

build-tools/package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
"temp-directory": "nyc/.nyc_output"
7373
},
7474
"devDependencies": {
75-
"@biomejs/biome": "~1.9.4",
75+
"@biomejs/biome": "~2.4.5",
7676
"@commitlint/cli": "^20.1.0",
7777
"@commitlint/config-conventional": "^20.0.0",
7878
"@commitlint/cz-commitlint": "^20.1.0",
@@ -146,18 +146,16 @@
146146
]
147147
},
148148
"overrideComments": [
149-
"biome is overridden to make review of the upgrade easier. This can be removed once merged.",
150149
"eslint: jssm-viz-cli brings in ESLint 8.x as a transitive dependency. Force ESLint 9.x to ensure consistent version across the workspace.",
151150
"oclif includes some AWS-related features, but we don't use them, so we override those dependencies with empty packages. This helps reduce lockfile churn since the deps release very frequently.",
152151
"@types/node: To avoid duplicating the oclif package and adding a bunch of dependencies, force @types/node to a single version. For some reason version 22.8.0 can't be overridden, so use that to ensure a single version",
153152
"@types/minimatch: @types/glob@7.x uses minimatch.IOptions and minimatch.IMinimatch interfaces. Force @types/minimatch@5 which includes these legacy type definitions.",
154153
"mdast-util-gfm-footnote: mdast-util-gfm@3.1.0 has a type definition bug where it imports ToMarkdownOptions from mdast-util-gfm-footnote, but version 2.0.0 doesn't export it. Override to 2.1.0 which includes the missing export."
155154
],
156155
"overrides": {
157-
"@biomejs/biome": "~2.3.11",
158-
"eslint": "~9.39.2",
159156
"@types/glob>@types/minimatch": "~5.1.2",
160157
"@types/node": "^22.19.1",
158+
"eslint": "~9.39.2",
161159
"json5@<1.0.2": "^1.0.2",
162160
"json5@>=2.0.0 <2.2.2": "^2.2.2",
163161
"mdast-util-gfm-footnote": "^2.1.0",

build-tools/packages/build-cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@
148148
"yaml": "^2.8.1"
149149
},
150150
"devDependencies": {
151-
"@biomejs/biome": "~1.9.4",
151+
"@biomejs/biome": "~2.4.5",
152152
"@fluidframework/build-common": "^2.0.3",
153153
"@oclif/test": "^4.1.15",
154154
"@types/async": "^3.2.25",

build-tools/packages/build-infrastructure/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
"typescript": "~5.4.5"
8080
},
8181
"devDependencies": {
82-
"@biomejs/biome": "~1.9.4",
82+
"@biomejs/biome": "~2.4.5",
8383
"@fluid-tools/api-markdown-documenter": "^0.23.0",
8484
"@fluidframework/build-common": "^2.0.3",
8585
"@fluidframework/build-tools-bin": "npm:@fluidframework/build-tools@~0.63.0",

build-tools/packages/build-tools/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"yaml": "^2.8.1"
6969
},
7070
"devDependencies": {
71-
"@biomejs/biome": "~1.9.4",
71+
"@biomejs/biome": "~2.4.5",
7272
"@fluidframework/build-common": "^2.0.3",
7373
"@fluidframework/build-tools-bin": "npm:@fluidframework/build-tools@~0.63.0",
7474
"@types/async": "^3.2.25",

build-tools/packages/bundle-size-tools/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"webpack": "^5.103.0"
4949
},
5050
"devDependencies": {
51-
"@biomejs/biome": "~1.9.4",
51+
"@biomejs/biome": "~2.4.5",
5252
"@fluidframework/build-common": "^2.0.3",
5353
"@fluidframework/build-tools-bin": "npm:@fluidframework/build-tools@~0.63.0",
5454
"@microsoft/api-extractor": "^7.55.1",

build-tools/packages/version-tools/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
"table": "^6.9.0"
8787
},
8888
"devDependencies": {
89-
"@biomejs/biome": "~1.9.4",
89+
"@biomejs/biome": "~2.4.5",
9090
"@fluidframework/build-common": "^2.0.3",
9191
"@fluidframework/build-tools-bin": "npm:@fluidframework/build-tools@~0.63.0",
9292
"@microsoft/api-extractor": "^7.55.1",

build-tools/pnpm-lock.yaml

Lines changed: 49 additions & 50 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build-tools/syncpack.config.cjs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -169,15 +169,6 @@ module.exports = {
169169
dependencies: ["@fluidframework/eslint-config-fluid"],
170170
},
171171

172-
{
173-
// TODO: This can be removed once biome is fully upgraded to 2.x
174-
label: "Ignore @biomejs/biome in pnpm overrides",
175-
isIgnored: true,
176-
packages: ["build-tools-release-group-root"],
177-
dependencies: ["@biomejs/biome"],
178-
dependencyTypes: ["pnpmOverrides"],
179-
},
180-
181172
{
182173
label: "chalk >2 is ESM only but build-tools and version-tools are still CJS only.",
183174
dependencies: ["chalk"],

0 commit comments

Comments
 (0)