[System Tests] fixed scale system tests (kroxylicious#2320)

* fixed scale system tests

Signed-off-by: Francisco Vila <fvila@redhat.com>

* remove unused constant

Signed-off-by: Francisco Vila <fvila@redhat.com>

---------

Signed-off-by: Francisco Vila <fvila@redhat.com>

Author: franvila

kroxylicious-systemtests/src/main/java/io/kroxylicious/systemtests/Constants.java

@@ -21,7 +21,6 @@ private Constants() {
      */
     public static final String KROXYLICIOUS_OPERATOR_DEPLOYMENT_NAME = "kroxylicious-operator";
     public static final String KROXYLICIOUS_OPERATOR_NAMESPACE = "kroxylicious-operator";
-    public static final String KROXYLICIOUS_DEPLOYMENT_NAME = "kroxylicious-proxy";
     public static final String KROXYLICIOUS_PROXY_SIMPLE_NAME = "simple";
     public static final String KROXYLICIOUS_INGRESS_CLUSTER_IP = "cluster-ip";
     public static final String KROXYLICIOUS_ENCRYPTION_FILTER_NAME = "encryption";

kroxylicious-systemtests/src/main/java/io/kroxylicious/systemtests/installation/kroxylicious/Kroxylicious.java

@@ -103,6 +103,12 @@ public void deployPortIdentifiesNodeWithTlsAndNoFilters(String clusterName) {
                         clusterName, Constants.KROXYLICIOUS_INGRESS_CLUSTER_IP));
     }
 
+    /**
+     * Deploy port identifies node with downstream tls and no filters.
+     *
+     * @param clusterName the cluster name
+     * @param tls the tls
+     */
     public void deployPortIdentifiesNodeWithDownstreamTlsAndNoFilters(String clusterName, Tls tls) {
         resourceManager.createResourceFromBuilder(
                 KroxyliciousKafkaProxyTemplates.defaultKafkaProxyCR(deploymentNamespace, Constants.KROXYLICIOUS_PROXY_SIMPLE_NAME, 1),
@@ -114,6 +120,12 @@ public void deployPortIdentifiesNodeWithDownstreamTlsAndNoFilters(String cluster
                         clusterName, Constants.KROXYLICIOUS_INGRESS_CLUSTER_IP, tls));
     }
 
+    /**
+     * Create certificate config map from listener.
+     *
+     * @param namespace the namespace
+     * @return the tls
+     */
     public Tls createCertificateConfigMapFromListener(String namespace) {
         // wait for listeners to contain data
         var tlsListenerStatus = KafkaUtils.getKafkaListenerStatus("tls");
@@ -145,6 +157,12 @@ private static TrustAnchorRef buildTrustAnchorRef() {
         // formatter:on
     }
 
+    /**
+     * Tls config from cert.
+     *
+     * @param certNane the cert nane
+     * @return the tls
+     */
     public Tls tlsConfigFromCert(String certNane) {
         TlsBuilder tlsBuilder = new TlsBuilder();
         if (certNane != null) {
@@ -218,7 +236,7 @@ public String getBootstrap(String clusterName) {
      */
     public int getNumberOfReplicas() {
         LOGGER.info("Getting number of replicas..");
-        return kubeClient().getDeployment(deploymentNamespace, Constants.KROXYLICIOUS_DEPLOYMENT_NAME).getStatus().getReplicas();
+        return kubeClient().getDeployment(deploymentNamespace, Constants.KROXYLICIOUS_PROXY_SIMPLE_NAME).getStatus().getReplicas();
     }
 
     /**
@@ -229,11 +247,17 @@ public int getNumberOfReplicas() {
      */
     public void scaleReplicasTo(int scaledTo, Duration timeout) {
         LOGGER.info("Scaling number of replicas to {}..", scaledTo);
-        kubeClient().getClient().resources(KafkaProxy.class).inNamespace(deploymentNamespace).withName(Constants.KROXYLICIOUS_DEPLOYMENT_NAME).scale(scaledTo);
+        kubeClient().getClient().resources(KafkaProxy.class).inNamespace(deploymentNamespace).withName(Constants.KROXYLICIOUS_PROXY_SIMPLE_NAME).scale(scaledTo);
         await().atMost(timeout).pollInterval(Duration.ofSeconds(1))
-                .until(() -> getNumberOfReplicas() == scaledTo && kubeClient().isDeploymentReady(deploymentNamespace, Constants.KROXYLICIOUS_DEPLOYMENT_NAME));
+                .until(() -> getNumberOfReplicas() == scaledTo && kubeClient().isDeploymentReady(deploymentNamespace, Constants.KROXYLICIOUS_PROXY_SIMPLE_NAME));
     }
 
+    /**
+     * Deploy port identifies node with no filters.
+     *
+     * @param clusterName the cluster name
+     * @param proxyPods the proxy pods
+     */
     public void deployPortIdentifiesNodeWithNoFilters(String clusterName, int proxyPods) {
         resourceManager.createResourceFromBuilder(
                 KroxyliciousKafkaProxyTemplates.defaultKafkaProxyCR(deploymentNamespace, Constants.KROXYLICIOUS_PROXY_SIMPLE_NAME, proxyPods),

kroxylicious-systemtests/src/main/java/io/kroxylicious/systemtests/templates/kroxylicious/KroxyliciousKafkaProxyTemplates.java

@@ -18,7 +18,7 @@ private KroxyliciousKafkaProxyTemplates() {
      *
      * @param namespaceName the namespace name
      * @param name the name
-     * @param replicas the number porxy pods to deploy
+     * @param replicas the number proxy pods to deploy
      * @return the kafka proxy builder
      */
     public static KafkaProxyBuilder defaultKafkaProxyCR(String namespaceName, String name, int replicas) {
@@ -29,7 +29,7 @@ public static KafkaProxyBuilder defaultKafkaProxyCR(String namespaceName, String
                     .withNamespace(namespaceName)
                 .endMetadata()
                 .withNewSpec()
-                .withReplicas(replicas)
+                    .withReplicas(replicas)
                 .endSpec();
         // @formatter:on
     }

kroxylicious-systemtests/src/test/java/io/kroxylicious/systemtests/KroxyliciousST.java

@@ -248,7 +248,7 @@ void setupBefore() {
         else {
             LOGGER.atInfo().setMessage("Deploying Kafka in {} namespace").addArgument(Constants.KAFKA_DEFAULT_NAMESPACE).log();
 
-            int numberOfBrokers = 1;
+            int numberOfBrokers = 3;
             KafkaBuilder kafka = KafkaTemplates.kafkaPersistentWithKRaftAnnotations(Constants.KAFKA_DEFAULT_NAMESPACE, clusterName, numberOfBrokers);
 
             resourceManager.createResourceFromBuilderWithWait(