Merge pull request #174 from tanmoysrt/improve_post_validation

refactor(physical-restore): Optimize table validations and repair

Author: tanmoysrt

agent/database_physical_restore.py

@@ -75,8 +75,8 @@ def create_restore_job(self):
         self.import_tablespaces_in_target_db()
         self.hold_write_lock_on_myisam_tables()
         self.perform_myisam_file_operations()
-        self.perform_post_restoration_validation_and_fixes()
         self.unlock_all_tables()
+        self.perform_post_restoration_validation_and_fixes()
 
     @step("Validate Backup Files")
     def validate_backup_files(self):  # noqa: C901
@@ -294,7 +294,11 @@ def perform_post_restoration_validation_and_fixes(self):
         """
 
         for table in innodb_tables_with_fts:
-            if self.is_table_corrupted(table) and not self.repair_table(table, "innodb"):
+            """
+            No need to waste time on checking whether index is corrupted or not
+            Because, physical restoration will not work for FULLTEXT index.
+            """
+            if not self.repair_table(table, "innodb"):
                 raise Exception(f"Failed to repair table {table}")
 
         """
@@ -311,16 +315,6 @@ def perform_post_restoration_validation_and_fixes(self):
             if self.is_table_corrupted(table) and not self.repair_table(table, "myisam"):
                 raise Exception(f"Failed to repair table {table}")
 
-        for table in self.innodb_tables:
-            if table in innodb_tables_with_fts:
-                continue
-            """
-            If other innodb tables are corrupted,
-            We can't repair the table in running database
-            """
-            if self.is_table_corrupted(table):
-                raise Exception(f"Failed to repair table {table}")
-
     @step("Unlock All Tables")
     def unlock_all_tables(self):
         self._get_target_db().execute_sql("UNLOCK TABLES;")
@@ -453,7 +447,7 @@ def is_table_corrupted(self, table_name: str) -> bool:
         """  # noqa: E501
         isError = False
         for row in result:
-            if row[2] == "error":
+            if row[2] == "error" or (row[2] == "warning" and table_name in self.myisam_tables):
                 isError = True
                 break
         return isError