Merge pull request #1734 from frappe/main-hotfix

chore: Minor Release v1.59.0

Author: shariquerik

crm/api/assignment_rule.py

@@ -24,7 +24,7 @@ def get_assignment_rules_list():
 
 
 @frappe.whitelist()
-def duplicate_assignment_rule(docname, new_name):
+def duplicate_assignment_rule(docname: str, new_name: str):
 	doc = frappe.get_doc("Assignment Rule", docname)
 	doc.name = new_name
 	doc.assignment_rule_name = new_name

crm/api/comment.py

@@ -66,7 +66,7 @@ def extract_mentions(html):
 
 
 @frappe.whitelist()
-def add_comment(reference_doctype, reference_name, content, attachments=None):
+def add_comment(reference_doctype: str, reference_name: str, content: str, attachments: list | None = None):
 	"""Add a comment to the given document
 
 	:param reference_doctype: Reference Doctype

crm/api/contact.py

@@ -27,11 +27,11 @@ def update_deals_email_mobile_no(doc):
 
 
 @frappe.whitelist()
-def get_linked_deals(contact):
+def get_linked_deals(contact: str):
 	"""Get linked deals for a contact"""
 
 	if not frappe.has_permission("Contact", "read", contact):
-		frappe.throw("Not permitted", frappe.PermissionError)
+		frappe.throw(_("Not permitted"), frappe.PermissionError)
 
 	deal_names = frappe.get_all(
 		"CRM Contacts",
@@ -64,10 +64,10 @@ def get_linked_deals(contact):
 
 
 @frappe.whitelist()
-def create_new(contact, field, value):
+def create_new(contact: str, field: str, value: str):
 	"""Create new email or phone for a contact"""
 	if not frappe.has_permission("Contact", "write", contact):
-		frappe.throw("Not permitted", frappe.PermissionError)
+		frappe.throw(_("Not permitted"), frappe.PermissionError)
 
 	contact = frappe.get_cached_doc("Contact", contact)
 
@@ -78,17 +78,17 @@ def create_new(contact, field, value):
 		mobile_no = {"phone": value, "is_primary_mobile_no": 1 if len(contact.phone_nos) == 0 else 0}
 		contact.append("phone_nos", mobile_no)
 	else:
-		frappe.throw("Invalid field")
+		frappe.throw(_("Invalid field"))
 
 	contact.save()
 	return True
 
 
 @frappe.whitelist()
-def set_as_primary(contact, field, value):
+def set_as_primary(contact: str, field: str, value: str):
 	"""Set email or phone as primary for a contact"""
 	if not frappe.has_permission("Contact", "write", contact):
-		frappe.throw("Not permitted", frappe.PermissionError)
+		frappe.throw(_("Not permitted"), frappe.PermissionError)
 
 	contact = frappe.get_doc("Contact", contact)
 
@@ -106,7 +106,7 @@ def set_as_primary(contact, field, value):
 			else:
 				phone.set(name, 0)
 	else:
-		frappe.throw("Invalid field")
+		frappe.throw(_("Invalid field"))
 
 	contact.save()
 	return True