fix: conditions in work order and production plan

Author: Nishka Gosalia

erpnext/manufacturing/doctype/production_plan/production_plan.py

@@ -368,7 +368,7 @@ def get_so_items(self):
 				(so_item.parent.isin(so_list))
 				& (so_item.docstatus == 1)
 				& ((so_item.stock_qty - so_item.stock_reserved_qty) > so_item.work_order_qty)
-				& ((so_item.is_closed == 0) | (so_item.is_closed.isnull()))
+				& (so_item.is_closed == 0)
 			)
 		)
 
@@ -433,7 +433,7 @@ def get_so_items(self):
 						.where((bom.item == pi.item_code) & (bom.is_active == 1))
 					)
 				)
-				& ((so_item.is_closed == 0) | (so_item.is_closed.isnull()))
+				& (so_item.is_closed == 0)
 			)
 		)
 
@@ -1544,7 +1544,7 @@ def get_sales_orders(self):
 			& (so.status.notin(["Stopped", "Closed"]))
 			& (so.company == self.company)
 			& (so_item.qty > so_item.production_plan_qty)
-			& ((so_item.is_closed == 0) | (so_item.is_closed.isnull()))
+			& (so_item.is_closed == 0)
 		)
 	)
 

erpnext/selling/doctype/sales_order/sales_order.js

@@ -1806,6 +1806,10 @@ erpnext.selling.SalesOrderController = class SalesOrderController extends erpnex
 					delivered_qty: d.delivered_qty,
 				};
 			});
+		if (!this.data.length) {
+			frappe.msgprint(__("No closed items to re-open"));
+			return;
+		}
 		const reopen_item_fields = [
 			{
 				fieldtype: "Link",
@@ -1845,7 +1849,7 @@ erpnext.selling.SalesOrderController = class SalesOrderController extends erpnex
 
 				let selected_items = (values.reopen_items || []).filter((row) => row.__checked);
 				if (!selected_items.length) {
-					frappe.msgprint(__("Please select one item to re-open"));
+					frappe.msgprint(__("Please select atleast one item to re-open"));
 					return;
 				}
 				frappe.call({
@@ -1881,6 +1885,10 @@ erpnext.selling.SalesOrderController = class SalesOrderController extends erpnex
 					delivered_qty: d.delivered_qty,
 				};
 			});
+		if (!this.data.length) {
+			frappe.msgprint(__("No items available to close"));
+			return;
+		}
 		const close_item_fields = [
 			{
 				fieldtype: "Link",