Skip to content

Commit dc7cfcb

Browse files
Nishka GosaliaNishka Gosalia
authored andcommitted
fix: handle for packed items as well
1 parent ed6a103 commit dc7cfcb

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

erpnext/patches/v16_0/update_sales_order_item_status.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def execute():
1212
).set(sales_order_item.is_closed, 1).where(
1313
(sales_order.name == sales_order_item.parent)
1414
& (sales_order.status == "Closed")
15-
& (sales_order_item.is_closed == 0)
15+
& ((sales_order_item.is_closed == 0) | sales_order_item.is_closed.isnull())
1616
).run()
1717
finally:
1818
frappe.db.auto_commit_on_many_writes = 0

erpnext/selling/doctype/sales_order/sales_order.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1992,11 +1992,16 @@ def get_work_order_items(sales_order, for_raw_material_request=0):
19921992
"Product Bundle", {"new_item_code": ["in", item_codes], "disabled": 0}, ["new_item_code"]
19931993
)
19941994
]
1995+
so_items_is_closed_map = {item.name: item.is_closed for item in so.items}
19951996

19961997
for table in [so.items, so.packed_items]:
19971998
for i in table:
1998-
if getattr(i, "is_closed", 0):
1999-
continue
1999+
if table == so.packed_items:
2000+
if so_items_is_closed_map.get(i.parent_detail_docname):
2001+
continue
2002+
else:
2003+
if getattr(i, "is_closed", 0):
2004+
continue
20002005

20012006
bom = get_default_bom(i.item_code)
20022007
stock_qty = i.qty if i.doctype == "Packed Item" else i.stock_qty

0 commit comments

Comments
 (0)