AttributeError: 'NoneType' object has no attribute 'name'

[akshat-ksolves]

Information about bug

Module

other

Version

ERPNext Version - 16

Installation method

None

Relevant log output / Stack trace / Full Error Message.

Traceback (most recent call last):
  File "apps/frappe/frappe/www/desk.py", line 30, in get_context
    boot = frappe.sessions.get()
  File "apps/frappe/frappe/sessions.py", line 144, in get
    bootinfo = get_bootinfo()
  File "apps/frappe/frappe/boot.py", line 59, in get_bootinfo
    load_desktop_data(bootinfo)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "apps/frappe/frappe/boot.py", line 164, in load_desktop_data
    allowed_pages = [d.name for d in bootinfo.workspaces.get("pages")]
                     ^^^^^^
AttributeError: 'NoneType' object has no attribute 'name'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "apps/frappe/frappe/website/serve.py", line 20, in get_response
    return renderer_instance.render()
           ~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 84, in render
    html = self.get_html()
  File "apps/frappe/frappe/website/utils.py", line 540, in cache_html_decorator
    html = func(*args, **kwargs)
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 95, in get_html
    self.update_context()
    ~~~~~~~~~~~~~~~~~~~^^
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 163, in update_context
    data = self.run_pymodule_method("get_context")
  File "apps/frappe/frappe/website/page_renderers/template_page.py", line 223, in run_pymodule_method
    return method(self.context)
  File "apps/frappe/frappe/www/desk.py", line 32, in get_context
    raise frappe.SessionBootFailed from e
frappe.exceptions.SessionBootFailed

[mihir-kandoi]

Could you please provide reproduction steps?

[akshat-ksolves]

This error occurs in ERPNext V16 when we create a user and provide role access but not module access. When this user logs in, they face this issue. Unless they are given the Workspace Manager role or access to the Core module, this issue persists. Without explicit module access, the system should not require Workspace "Manager" to show the records and not break the code.

@mihir-kandoi

[ankush]

frappe/frappe/desk/desktop.py

Lines 492 to 493 in 8bfb42d

	if len(pages) == 0:
	pages.append(next((x for x in all_pages if x["title"] == "Welcome Workspace"), None))

@sokumon