Skip to content

insert_many requires frappe as a library #38

@MarekPikula

Description

@MarekPikula

insert_many method calls frappe.as_json, which in essence is (source):

json.dumps(obj, indent=indent, sort_keys=True, default=json_handler, separators=(',', ': '))

I guess entire frappe package shouldn't be a dependence on such a small library, especially since it's only used to call this method. In other methods simple json.dumpsis used. Why cannot it be used in import_many as well?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions